Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared task dict BUG #549

Closed
wants to merge 1 commit into from
Closed

Fix shared task dict BUG #549

wants to merge 1 commit into from

Conversation

you-n-g
Copy link
Collaborator

@you-n-g you-n-g commented Aug 8, 2021

Fix shared task dict BUG

Description

The task t is shared when generating rolling tasks.
Modification on new tasks will affect old tasks

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator Author

you-n-g commented Aug 25, 2021

We've fixed a CI error recently 509bfcb
Please rebase the PR to the main branch or merge the main branch to pass the CI test.

Thanks

@you-n-g you-n-g mentioned this pull request Aug 25, 2021
5 tasks
@you-n-g you-n-g closed this Aug 25, 2021
@you-n-g you-n-g deleted the online-hotfix branch September 26, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant