-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crypto dataset from coingecko #733
Conversation
@b4thesunrise |
thanks for your help! will remove it in later commit. |
have already implement the change, please give it a review :) |
Hi, currently |
@b4thesunrise
You can choose either of them as you wish. |
Hi, so to support backtest, the data need to support all the features of $close/$open/$low/$high/$volume/$change/$factor, don't know if I understand it correctly? If true, the currently data source do not support OHLC and I will choose to describe the limitation in the file. |
@b4thesunrise Yes. You understand it correctly. |
Got it, so busy for these two weeks, plan to update the docs and new code version at 12.30. |
|
It looks great! |
* add crypto symbols collectors * add crypto data collector * add crypto symbols collectors * add crypto data collector * solver region and source problem * fix merge * fix merge * clean all cn information Co-authored-by: DefangCui <170007807@pku.edu.cn>
Description
Add collector in scripts to add crypto data
Motivation and Context
#716
solve the lack of crypto data, which is a need for many people(this need has been raised in gitter also)
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.ran the scripts in readme successfully
Screenshots of Test Results (if appropriate):
Types of changes