This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Only check type resolutions for cycles where every callable is type parameterized #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
approved these changes
Apr 14, 2022
ScottCarda-MS
approved these changes
Apr 14, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sure thing! Disabled the auto merge so we can sync up tomorrow. |
|
@swernli and I had a chat, and I'm all caught up. This looks ready to merge in. Thanks! |
swernli
added a commit
to microsoft/qsharp-runtime
that referenced
this pull request
May 3, 2022
Now that the fix from microsoft/qsharp-compiler#1411 has made it into the release, the QDK version can be updated to the April release instead of a beta version.
swernli
added a commit
to microsoft/qsharp-runtime
that referenced
this pull request
May 15, 2022
Now that the fix from microsoft/qsharp-compiler#1411 has made it into the release, the QDK version can be updated to the April release instead of a beta version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be more efficient to just store whether a node in the call graph has type parameters along with the node.