Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@filipw
Copy link
Contributor

@filipw filipw commented Mar 3, 2020

At the moment most of the language server features do not work when opening the project on the UNC path (shared network, a Mac folder on a Parallels Windows VM etc). See this GIF:

4fDZHrWr6G

This is caused by using Uri.AbsolutePath instead of LocalPath.

There is really no way to have a test for this, but I tested using "quantumDevKit.languageServerPath" and it seems to solve the issue, see below (notice the UNC path of this project):

Screenshot 2020-03-03 20 50 46

@cgranade cgranade requested a review from bettinaheim March 3, 2020 19:54
@filipw
Copy link
Contributor Author

filipw commented Mar 3, 2020

actually, I posted screenshots from VS Code only, but it's the same for VS too

@bettinaheim
Copy link
Contributor

Hi @filipw,
Sorry for the delay with processing this. I meant to double check whether everything works still fine in our generated code, and didn't get around to it yet. Hopefully it shouldn't be too long.

@filipw
Copy link
Contributor Author

filipw commented Mar 10, 2020

thanks a lot 👍

@ricardo-espinoza ricardo-espinoza self-requested a review June 18, 2020 05:28
@ricardo-espinoza
Copy link
Contributor

Thanks a lot @filipw for reporting this issue and contributing with the fix. We’ve reviewed and tested it and it looks good.

Marking as Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants