This repository was archived by the owner on Jan 12, 2024. It is now read-only.
use local path for UNC files in language server #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment most of the language server features do not work when opening the project on the UNC path (shared network, a Mac folder on a Parallels Windows VM etc). See this GIF:
This is caused by using
Uri.AbsolutePathinstead ofLocalPath.There is really no way to have a test for this, but I tested using
"quantumDevKit.languageServerPath"and it seems to solve the issue, see below (notice the UNC path of this project):