This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix #256. #257
Merged
Fix #256. #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-runtime into cgranade/fix-256
ScottCarda-MS
approved these changes
Jun 22, 2020
bettinaheim
approved these changes
Jun 23, 2020
yusudz
pushed a commit
that referenced
this pull request
Jul 8, 2020
yusudz
added a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #256 by simplifying random sampling logic and by fixing the case in which the sampled element should have been the last one in the categorical distribution.