Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@IrinaYatsenko
Copy link
Contributor

Fixes #189

I'm not sure what the expected behavior is for the "Width" metric. Personally, I'd expect it to report the max of widths across the runs, not adding the per-run widths. However, I'd rather not have special logic for width in the processing loop because it would have to rely on the label and will be fragile, so I've added the max column to the results for all metrics. Is it useful to know the highest count across operations for gates or measurements? The data can be accessed programmatically, as the new test demonstrates, but I didn't update the ToTSV method to include it -- should I? If we go this route the documentation (https://docs.microsoft.com/en-us/quantum/machines/resources-estimator) also will need to be updated.

Copy link
Member

@msoeken msoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some minor comments. I think it would be convenient to have a Clear() or Reset() method on ResourcesEstimator having this new behaviour.

@IrinaYatsenko
Copy link
Contributor Author

I just left some minor comments. I think it would be convenient to have a Clear() or Reset() method on ResourcesEstimator having this new behaviour.

How having Clear/Reset is different from creating a new simulator? Does providing this additional functionality (that needs to be documented and tested) make user experience better? I'm not saying we shouldn't do it, but clearing methods are notorious for being confusing to the users and causing subtle bugs. I believe we should do it only if the perf benefits of reusing the simulator to get non-aggregated results provably exist.

Copy link
Contributor

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@IrinaYatsenko IrinaYatsenko merged commit 6eb9d45 into master Jun 25, 2020
@IrinaYatsenko IrinaYatsenko deleted the irinayat/189-mult-runs-resource-estimator branch October 7, 2020 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResourcesEstimator instance shows wrong estimates when used more than once

4 participants