This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add Runtime Metadata to Operations #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theRoughCode
force-pushed
the
raphael/tracer
branch
from
29e0bbc to
a7ed4e3
Compare
theRoughCode
requested review from
anpaz,
cgranade,
ricardo-espinoza and
rmshaffer
cgranade
reviewed
Jul 10, 2020
6 tasks
theRoughCode
force-pushed
the
raphael/tracer
branch
from
67a1ed7 to
009b15c
Compare
cgranade
reviewed
Jul 13, 2020
anpaz
suggested changes
Jul 13, 2020
theRoughCode
commented
Jul 14, 2020
anpaz
suggested changes
Jul 15, 2020
added 8 commits
July 15, 2020 11:26
…->GetNonQubitArguments
|
There was a weird Github bug where my changes weren't showing after merging master in. I tried rebasing onto master instead but again, the changes weren't showing up on this PR specifically. Turns out this is a known bug for years and the solution involved having to switch the base branches. |
theRoughCode
force-pushed
the
raphael/tracer
branch
from
53631d2 to
b737581
Compare
added 4 commits
July 15, 2020 13:27
anpaz
approved these changes
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some code from this PR to this repo.
We add a
GetRuntimeMetadatamethod toICallables that contains metadata to be used by theExecutionPathTracerin that the iqsharp repo. The reason for moving the logic over here is to prevent circular dependencies between repos and to increase the modularity of defining customRuntimeMetadatafor each operation.The default
RuntimeMetadatais defined inOperations.cs, and any custom logic is overridden in the operation's specific namespace.Tests are added that test the output of
GetRuntimeMetadataof each of the custom logic we defined.