This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update to C++17 #310
Merged
Update to C++17 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
requested review from
AniketDalvi,
anpaz,
bamarsha,
bettinaheim and
dbwz8
swernli
commented
Jul 14, 2020
| #if (SAFEINT_COMPILER == CLANG_COMPILER || SAFEINT_COMPILER == GCC_COMPILER) && CPLUSPLUS_STD < CPLUSPLUS_11 | ||
| #error Must compile with --std=c++11, preferably --std=c++14 to use constexpr improvements | ||
| #if (SAFEINT_COMPILER == CLANG_COMPILER || SAFEINT_COMPILER == GCC_COMPILER) && CPLUSPLUS_STD < CPLUSPLUS_17 | ||
| #error Must compile with --std=c++17 |
Collaborator
Author
There was a problem hiding this comment.
Note that this changes the build requirement for clang and gcc to C++17, where previously this file would have accepted and attempted to handle anything down to C++11. That said, the CMakeLists.txt for all the code under src\Native already had C++14 as the required standard, so I don't believe our support of C++11 was genuine here. Given that after this switch we will start incorporating C++17 only features, it felt appropriate to update this requirement too.
dbwz8
approved these changes
Jul 14, 2020
Contributor
dbwz8
left a comment
dbwz8
left a comment
There was a problem hiding this comment.
I assume you've tested the build on both Windows and Linux.
Collaborator
Author
anpaz
approved these changes
Jul 14, 2020
matthiastroyer
approved these changes
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CMake build configuration for the native simulator to use and require C++17. This will allow us to support C++17 specific features, such as
std::optionalandstd::any.