Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Allow operations in arguments for GetNonQubitArgumentsAsString #314

Merged
Parent: Testing
merged 2 commits into from
Jul 22, 2020
Merged

Allow operations in arguments for GetNonQubitArgumentsAsString #314

merged 2 commits into from
Jul 22, 2020

Conversation

@theRoughCode
Copy link
Contributor

Currently, an ICallable in would match the IApplyData case in GetNonQubitArgumentsAsString. This would throw a NullException because its IApplyData.Value is null. This PR adds a new check for ICallables and returns its name as a string.

@theRoughCode theRoughCode requested review from anpaz and cgranade July 20, 2020 20:23
@theRoughCode theRoughCode self-assigned this Jul 20, 2020
anpaz
anpaz approved these changes Jul 22, 2020
View reviewed changes
@theRoughCode theRoughCode merged commit 49393b9 into master Jul 22, 2020
@theRoughCode theRoughCode deleted the raphael/op-args branch July 22, 2020 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cgranade cgranade Awaiting requested review from cgranade

1 more reviewer

@anpaz anpaz anpaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@theRoughCode theRoughCode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theRoughCode @anpaz