Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%%qsharp cell failures should mark the cell as failed #1071

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

minestarks
Copy link
Member

@minestarks minestarks commented Jan 24, 2024

When a %%qsharp cell throws a compiler or runtime error, the whole should be marked as an error, just as when Python code throws an exception.

Related: #1070 . When we test notebooks in automation, we want to catch any failures in Q# cells.

VS Code before/after side by side:

image

Jupyter notebook before/after side by side:

image

Copy link

Benchmark for 966d9af

Click to view benchmark
Test Base PR %
Array append evaluation 875.7±9.44µs 875.3±7.11µs -0.05%
Array update evaluation 953.4±6.01µs 950.0±4.29µs -0.36%
Deutsch-Jozsa evaluation 31.5±0.20ms 31.5±0.22ms 0.00%
Large file parity evaluation 36.1±0.11ms 36.1±0.12ms 0.00%
Large input file 40.5±0.58ms 41.0±0.74ms +1.23%
Standard library 22.0±0.44ms 22.6±0.77ms +2.73%
Teleport evaluation 104.6±1.97µs 104.3±2.47µs -0.29%

Copy link

Benchmark for fea2ccc

Click to view benchmark
Test Base PR %
Array append evaluation 876.2±6.38µs 863.7±9.83µs -1.43%
Array update evaluation 954.9±7.48µs 936.3±15.48µs -1.95%
Deutsch-Jozsa evaluation 31.3±0.24ms 31.1±0.20ms -0.64%
Large file parity evaluation 35.9±0.07ms 35.9±0.13ms 0.00%
Large input file 38.2±0.55ms 37.8±0.57ms -1.05%
Standard library 20.7±0.21ms 20.7±0.78ms 0.00%
Teleport evaluation 104.2±3.05µs 103.1±2.73µs -1.06%

@minestarks minestarks added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 64cd7b9 Jan 26, 2024
14 checks passed
@minestarks minestarks deleted the minestarks/python-cell-error branch January 26, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants