Move the Location struct to a more common place #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
requested review from
billti,
cesarzc,
swernli,
idavis and
ScottCarda-MS
as code owners
ScottCarda-MS
approved these changes
Feb 2, 2024
swernli
approved these changes
Feb 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…#1107) Depends on #1106 VSCode's debugging related APIs sometimes use filesystem paths instead of URIs to represent sources. Previously, our solution was to have a `FileAccessor` which tried to treat the path both ways (first as a filesystem path, then a URI). But by being strategic about exactly where we expect filesystem paths and sanitizing them, we can just consistently use URIs in the rest of the code. Additionally this PR introduces integration tests for the debugger. We also fix two small-ish bugs here: - launch.json variables like `{file}` and `{workspaceFolder}` weren't treated properly on all platforms/filesystems - when launching the debugger on an untitled file, the user may be prompted to save the file. If they choose to save the file, the debugger will fail to launch. (This is probably not as big an issue anymore, since we disabled the auto-save behavior by default since I've opened this PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Locationrefers to a span within a specific source file. It's expressed as a source name andRange. See: https://github.com/microsoft/vscode/blob/7923151da4b3567636c1346df9e8ba682744bbf3/src/vscode-dts/vscode.d.ts#L6581It was defined in the language service protocol, but I'm moving it to a more common location in
compiler/qscsince I need the debugger to use it in #1107.To summarize this PR and #1038, here's how locations are represented in the compiler vs. higher-level components that interface with VS Code (debugger, language service):
u32offset (intoSourceMap)Position(into specific source file)SpanRangePackageId,Span)Location