Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign flip, basis change, amplitude change tasks to Single-Qubit Gates kata #1352

Merged
merged 18 commits into from
Apr 6, 2024

Conversation

WWhitedogi
Copy link
Contributor

Add amplitude_change task, basis_change task, sign_flip task, Common.qs file to Single-Qubit Gates kata.

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a pass and left some comments, mostly formatting, a few on doing testing slightly differently to match the task definition better.

Thank you!

katas/content/single_qubit_gates/index.md Show resolved Hide resolved
katas/content/single_qubit_gates/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/sign_flip/Placeholder.qs Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/sign_flip/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/Common.qs Outdated Show resolved Hide resolved
WWhitedogi and others added 12 commits April 2, 2024 22:12
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@tcNickolas
Copy link
Member

I think some of the comments are still unresolved - let me know if you have any questions about them! (Just want to make sure you're not blocked on anything here)

Use CheckOperationsEquivalenceStrict() and superposition states for verify!
Use CheckOperationsEquivalenceStrict and superposition state for verify.
Put after Ry gate is introduced, before Prepare Rotated State task
Adjust basis_task's order.
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@tcNickolas tcNickolas changed the title Add task1.2to1.4 to Single-Qubit Gates kata Add sign flip, basis change, amplitude change tasks to Single-Qubit Gates kata Apr 6, 2024
@tcNickolas tcNickolas added this pull request to the merge queue Apr 6, 2024
Merged via the queue into microsoft:main with commit e3fa674 Apr 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants