-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sign flip, basis change, amplitude change tasks to Single-Qubit Gates kata #1352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pass and left some comments, mostly formatting, a few on doing testing slightly differently to match the task definition better.
Thank you!
katas/content/single_qubit_gates/amplitude_change/Verification.qs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
I think some of the comments are still unresolved - let me know if you have any questions about them! (Just want to make sure you're not blocked on anything here) |
Use CheckOperationsEquivalenceStrict() and superposition states for verify!
Use CheckOperationsEquivalenceStrict and superposition state for verify.
Put after Ry gate is introduced, before Prepare Rotated State task
Adjust basis_task's order.
Delete Common.qs file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Add amplitude_change task, basis_change task, sign_flip task, Common.qs file to Single-Qubit Gates kata.