Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Teleportation Task 1.1 #1468

Merged
merged 6 commits into from
May 22, 2024
Merged

Added Teleportation Task 1.1 #1468

merged 6 commits into from
May 22, 2024

Conversation

devikamehra
Copy link
Contributor

Added first task for the teleportation kata (1.1)

As part of the migration - #1185

tcNickolas
tcNickolas requested changes May 4, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I left some comments, mostly along the lines of introducing the protocol and unifying the code with other katas.

Thank you!

katas/content/teleportation/entangled_pair/Solution.qs Outdated Show resolved Hide resolved
katas/content/teleportation/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/entangled_pair/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/entangled_pair/Verification.qs Outdated Show resolved Hide resolved
katas/content/teleportation/index.md Show resolved Hide resolved
katas/content/teleportation/entangled_pair/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/entangled_pair/solution.md Outdated Show resolved Hide resolved
@devikamehra devikamehra requested a review from tcNickolas May 21, 2024 11:29
tcNickolas
tcNickolas approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and consistent with the final version of Superdense Coding kata, so should work well together. I have a few minor comments on whitespace and operation naming, but I can apply them myself before merging.

Thank you!

katas/content/teleportation/entangled_pair/index.md Outdated Show resolved Hide resolved
katas/content/teleportation/Common.qs Outdated Show resolved Hide resolved
katas/content/teleportation/entangled_pair/Verification.qs Outdated Show resolved Hide resolved
katas/content/teleportation/entangled_pair/Verification.qs Outdated Show resolved Hide resolved
@tcNickolas tcNickolas enabled auto-merge May 22, 2024 02:04
@devikamehra
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tcNickolas tcNickolas added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit ea10af9 May 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti billti left review comments

@cesarzc cesarzc Awaiting requested review from cesarzc

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devikamehra @billti @tcNickolas