Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Measurements task 2.1 to Distinguishing States Kata #1518

Merged
merged 9 commits into from
May 27, 2024
Merged

Add Measurements task 2.1 to Distinguishing States Kata #1518

merged 9 commits into from
May 27, 2024

Conversation

JPark1023
Copy link
Contributor

Added Common.qs, media folder, zero-plus folder containing task and updated index

Resolves part of #1185

tcNickolas
tcNickolas requested changes May 22, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and testing works nicely. I left some minor formatting comments

Thank you!

katas/content/distinguishing_states/zero_plus/index.md Outdated Show resolved Hide resolved
katas/content/distinguishing_states/zero_plus/solution.md Outdated Show resolved Hide resolved
katas/content/distinguishing_states/zero_plus/solution.md Outdated Show resolved Hide resolved
katas/content/distinguishing_states/zero_plus/Solution.qs Outdated Show resolved Hide resolved
katas/content/distinguishing_states/zero_plus/solution.md Outdated Show resolved Hide resolved
katas/content/distinguishing_states/Common.qs Outdated Show resolved Hide resolved
katas/content/distinguishing_states/Common.qs Outdated Show resolved Hide resolved
@tcNickolas
Copy link
Member

You'll also need to add this kata to the list at index.json temporarily, so that CI builds validate it, and I'll remove it from the list before merging. I do this locally when testing this change, but it's better to let CI validate it as well

tcNickolas
tcNickolas approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll remove the kata from the list and merge it once the CI is done

Thank you!

katas/content/index.json Outdated Show resolved Hide resolved
@tcNickolas tcNickolas enabled auto-merge May 26, 2024 18:40
@JPark1023
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tcNickolas tcNickolas added this pull request to the merge queue May 27, 2024
Merged via the queue into microsoft:main with commit b77aa66 May 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti billti left review comments

@cesarzc cesarzc Awaiting requested review from cesarzc

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPark1023 @tcNickolas @billti