-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unitary hack] Add doc for internal AND #1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! An additional recommendation for the API that should be included in the documentation is the assumption that when the normal/non-adjoint specialization is called the target
qubit is expected to be in the zero or ground state. I'm not quite sure how to phrase that guidance, exactly, but I think it's worth finding a way to include that in the Summary section.
@swernli thanks for your review. I have update documentation and updated PR description as per your feedback. The previous CI run failed on integration test(https://github.com/microsoft/qsharp/actions/runs/9281069142) and it seems unrelated, so I merged latest main. |
Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
Looks like the change to the stdlib made some debugger tests fail because they confirm the line number that the debugger breaks into. Since the file contents changed, the line numbers have to be updated. A little annoying but an expected consequence of the change. |
Thanks @swernli for looking into this. I have updated the failing IT based on CI build failures. Do you know how can I run
|
To run the integration tests, you should be able to use the same python build script, but pass an additional flag: |
Thanks @swernli , the integration tests are passing locally for me now. |
@minestarks could you please help with code owner approval |
@swernli , @minestarks , @tcNickolas , could you please merge this PR since I have the required approvals. |
@Manvi-Agrawal I will merge this PR as soon as the |
Fixes #1212.