Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset zoom level when circuit window is resized #1592

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

minestarks
Copy link
Member

Fixes a minor UI annoyance where the circuit shows up too small due to the narrow window width, and you have to click on the little Zoom button to make it bigger. Now, we resize automatically when the window itself is resized.

window-resize-circuit

Copy link

Benchmark for beeba1e

Click to view benchmark
Test Base PR %
Array append evaluation 331.9±1.74µs 333.1±1.86µs +0.36%
Array literal evaluation 184.3±1.88µs 172.0±12.43µs -6.67%
Array update evaluation 411.6±1.41µs 412.5±5.13µs +0.22%
Core + Standard library compilation 20.6±1.20ms 19.4±0.94ms -5.83%
Deutsch-Jozsa evaluation 5.1±0.05ms 5.2±0.21ms +1.96%
Large file parity evaluation 33.9±0.08ms 33.9±0.18ms 0.00%
Large input file compilation 12.9±0.43ms 13.2±0.52ms +2.33%
Large input file compilation (interpreter) 50.0±1.58ms 50.1±1.44ms +0.20%
Large nested iteration 32.9±0.24ms 33.0±0.64ms +0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1595.9±110.56µs 1575.8±68.97µs -1.26%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.15ms 7.9±0.12ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1461.8±119.44µs 1434.6±75.73µs -1.86%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.5±0.41ms 28.5±0.44ms 0.00%
Teleport evaluation 91.4±3.52µs 90.1±3.84µs -1.42%

@minestarks minestarks added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 74a7670 Jun 5, 2024
16 checks passed
@minestarks minestarks deleted the minestarks/circuit-resize-zoom branch June 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants