-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support qubit count tracking within Q# #1800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
force-pushed
the
swernli/issue1155
branch
from
August 5, 2024 05:18
0329c4f
to
19af3dd
Compare
billti
reviewed
Aug 5, 2024
billti
reviewed
Aug 5, 2024
swernli
force-pushed
the
swernli/issue1155
branch
from
August 5, 2024 23:04
19af3dd
to
5c3bdab
Compare
swernli
requested review from
cesarzc,
DmitryVasilevsky,
idavis and
minestarks
as code owners
August 13, 2024 17:58
billti
approved these changes
Aug 13, 2024
tcNickolas
reviewed
Aug 14, 2024
tcNickolas
reviewed
Aug 14, 2024
tcNickolas
reviewed
Aug 14, 2024
One more thing that needs a test case - in the chat we discussed "because multi-controlled gates are decomposed during simulation the same way they are for hardware, they will allocate additional auxiliary qubits proportional to the number of control qubits, which will show up in the count." - there is no test case with a controlled functor right now |
swernli
force-pushed
the
swernli/issue1155
branch
from
August 15, 2024 06:08
5c3bdab
to
30aa424
Compare
tcNickolas
approved these changes
Aug 15, 2024
This introduces qubit count tracking APIs to the Diagnostics namespace that allow Q# code to get counts for how many unique qubits are used during a section of execution. This is useful in katas and auto-grading scenarios to verify that exercise restrictions are being appropriately followed. Fixes #1155
swernli
force-pushed
the
swernli/issue1155
branch
from
August 15, 2024 21:18
30aa424
to
973ece3
Compare
Change in memory usage detected by benchmark. Memory Report for 5ee2b12
|
Benchmark for 5ee2b12Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces qubit count tracking APIs to the Diagnostics namespace that allow Q# code to get counts for how many unique qubits are used during a section of execution. This is useful in katas and auto-grading scenarios to verify that exercise restrictions are being appropriately followed.
Fixes #1155