Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Katas UI review - Multiqubit systems #1813

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Katas UI review - Multiqubit systems #1813

merged 13 commits into from
Aug 13, 2024

Conversation

SoniaLopezBravo
Copy link
Contributor

No description provided.

tcNickolas
tcNickolas requested changes Aug 2, 2024
View reviewed changes
katas/content/multi_qubit_systems/bell_state_change_1/solution.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/bell_state_change_3/solution.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/index.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/index.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/index.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/prepare_with_complex/solution.md Outdated Show resolved Hide resolved
katas/content/multi_qubit_systems/prepare_with_complex/solution.md Outdated Show resolved Hide resolved
katas/content/oracles/index.md Outdated Show resolved Hide resolved
katas/content/qec_shor/index.md Outdated Show resolved Hide resolved
katas/content/qubit/index.md Outdated Show resolved Hide resolved
SoniaLopezBravo and others added 8 commits August 5, 2024 18:23
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/bell_state_change_1/solution.md
db56751 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/bell_state_change_3/solution.md
68569a7 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/index.md
05291fa 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/index.md
86d6dc1 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/prepare_with_complex/solutio…
e3e1e7c 
…n.md

Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/prepare_with_complex/solutio…
b105f87 
…n.md

Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/multi_qubit_systems/learn_basis_state_amplitudes…
3696369 
…/index.md

Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo
Changing "knowledge" for "concepts"
8dac623
tcNickolas
tcNickolas reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Basic single-qubit gates" means the simple kinds of gates - X, Z, H. "Basic concepts of single-qubit gates" and "of measurements" is technically valid English, I think, but it doesn't really sound natural, and "Basic concepts of qubits" is not valid. Let's use the following terminology:

  • If a kata calls out concept of qubit specifically, like random numbers, let's drop it, if we ask for measurements and gates it's included
  • Basic single-qubit quantum gates (or multi-qubit if the kata calls for it)
  • Quantum measurements
  • Basic concepts of complex arithmetic
  • Basic concepts of linear algebra

Are there any other prerequisites that show up consistently and need a consistent reference to them?
Are there any

@SoniaLopezBravo
Copy link
Contributor Author

"Basic single-qubit gates" means the simple kinds of gates - X, Z, H. "Basic concepts of single-qubit gates" and "of measurements" is technically valid English, I think, but it doesn't really sound natural, and "Basic concepts of qubits" is not valid. Let's use the following terminology:

  • If a kata calls out concept of qubit specifically, like random numbers, let's drop it, if we ask for measurements and gates it's included
  • Basic single-qubit quantum gates (or multi-qubit if the kata calls for it)
  • Quantum measurements
  • Basic concepts of complex arithmetic
  • Basic concepts of linear algebra

Are there any other prerequisites that show up consistently and need a consistent reference to them? Are there any

There are other topics such as Oracles and Grover's search algorithm, that we can leave as they are.

@tcNickolas tcNickolas mentioned this pull request Aug 13, 2024
Closed
@tcNickolas @ScottCarda-MS
Update katas/content/multi_qubit_systems/prepare_with_real/solution.md
5e15be0 
Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
@tcNickolas tcNickolas added this pull request to the merge queue Aug 13, 2024
Merged via the queue into microsoft:main with commit f354f54 Aug 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky approved these changes

@ScottCarda-MS ScottCarda-MS ScottCarda-MS approved these changes

@sezna sezna sezna approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SoniaLopezBravo @tcNickolas @sezna @ScottCarda-MS @DmitryVasilevsky