Fix duplicate imports being generated when using completions #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sezna
force-pushed
the
alex/rework-context-finder
branch
from
8643870 to
0a32f63
Compare
sezna
force-pushed
the
alex/rework-context-finder
branch
from
0a32f63 to
bf9c468
Compare
sezna
requested review from
billti,
idavis,
minestarks and
ScottCarda-MS
as code owners
Benchmark for ca9f447Click to view benchmark
|
ScottCarda-MS
approved these changes
Aug 8, 2024
Benchmark for af48683Click to view benchmark
|
Benchmark for 993880eClick to view benchmark
|
billti
reviewed
Aug 13, 2024
Benchmark for c03aa09Click to view benchmark
|
orpuente-MS
approved these changes
Aug 15, 2024
Benchmark for acb46c3Click to view benchmark
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…s generation for callables (#1863) This PR closes #1862. I had previously touched this function in #1820. I did my best to port it and maintain existing functionality, but there was one conditional that I messed up, and it was around callables originating from the same file. This PR fixes the bug that caused. But also, this PR tries to simplify `callable_decl_to_completion_item` so this is less likely to happen in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1777
Closes #1775
This PR updates completions in the following ways:
completions.rsa bit -- it had some very, very nested code that was hard to make sense of.ignore_internal_callabletest, which was testinginternalas if it would make things private to a single namespace, when actuallyinternalmeans private to a package.Recognizing a preexisting glob import:
Screen.Recording.2024-08-06.at.5.48.17.PM.mov
Recognizing a preexisting alias:
Screen.Recording.2024-08-06.at.6.11.01.PM.mov