Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start migration of Phase Estimation kata #1824

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Start migration of Phase Estimation kata #1824

merged 3 commits into from
Aug 12, 2024

Conversation

tcNickolas
Copy link
Member

  • First two exercises match the last two exercises from classic Linear Algebra kata, and follow a similar approach for migrating it to Q#, replacing Python code with a hardcoded exercise
  • Third exercise is 1.3 from classic PhaseEstimation kata, rewritten to work with Boolean checks rather than assertions.

Part 2 will include exercises 2.1 and 1.4 from classic PhaseEstimation kata and new (to katas) QPE algorithm theory and demo of its success probability

Copy link

github-actions bot commented Aug 7, 2024

Benchmark for fb76fea

Click to view benchmark
Test Base PR %
Array append evaluation 341.1±2.81µs 340.5±2.01µs -0.18%
Array literal evaluation 168.5±0.90µs 185.4±1.55µs +10.03%
Array update evaluation 422.4±2.35µs 418.4±3.30µs -0.95%
Core + Standard library compilation 20.9±0.05ms 21.1±0.22ms +0.96%
Deutsch-Jozsa evaluation 5.0±0.06ms 5.0±0.06ms 0.00%
Large file parity evaluation 34.4±0.24ms 34.5±0.53ms +0.29%
Large input file compilation 12.6±0.13ms 12.5±0.12ms -0.79%
Large input file compilation (interpreter) 48.3±0.70ms 48.4±0.59ms +0.21%
Large nested iteration 33.3±0.27ms 33.4±0.20ms +0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1559.1±29.37µs 1560.5±27.81µs +0.09%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.04ms 7.7±0.06ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1416.2±26.10µs 1421.2±29.42µs +0.35%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.5±0.10ms 27.6±0.17ms +0.36%
Teleport evaluation 92.1±3.29µs 92.0±3.74µs -0.11%

Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, otherwise looks good.

katas/content/phase_estimation/index.md Outdated Show resolved Hide resolved
katas/content/phase_estimation/index.md Outdated Show resolved Hide resolved
katas/content/phase_estimation/state_eigenvector/index.md Outdated Show resolved Hide resolved
katas/content/phase_estimation/index.md Outdated Show resolved Hide resolved
Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
Copy link

github-actions bot commented Aug 7, 2024

Benchmark for 922f2fb

Click to view benchmark
Test Base PR %
Array append evaluation 337.9±11.57µs 338.7±1.99µs +0.24%
Array literal evaluation 168.4±0.90µs 168.5±1.03µs +0.06%
Array update evaluation 416.9±8.25µs 419.2±7.63µs +0.55%
Core + Standard library compilation 22.9±0.69ms 21.5±0.45ms -6.11%
Deutsch-Jozsa evaluation 4.9±0.05ms 5.0±0.05ms +2.04%
Large file parity evaluation 34.5±0.80ms 34.7±0.74ms +0.58%
Large input file compilation 13.0±0.40ms 13.2±0.36ms +1.54%
Large input file compilation (interpreter) 50.7±1.34ms 50.0±1.22ms -1.38%
Large nested iteration 33.3±2.13ms 33.4±0.24ms +0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1598.9±120.24µs 1582.3±45.99µs -1.04%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.08ms 8.0±0.24ms +1.27%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1450.5±88.78µs 1423.9±46.66µs -1.83%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.1±0.19ms 27.9±0.68ms -0.71%
Teleport evaluation 91.9±3.39µs 93.0±5.04µs +1.20%

@tcNickolas tcNickolas added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit a8b00c8 Aug 12, 2024
19 checks passed
@tcNickolas tcNickolas deleted the mariia/qpe-1 branch August 12, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants