New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic interop with Qiskit #1899

Merged

idavis merged 46 commits into main from iadavis/ast-to-ast

Sep 9, 2024

Collaborator

idavis commented Sep 3, 2024 •

edited

Loading

This PR adds the ability to resource estimate, run, and generate QIR from Qiskit QuantumCircuits.

There are three areas which we can break up the review into:

compiler/qsc_qasm3
Python user facing API and notebooks. Example usage can be seen in:
- samples/python_interop/qiskit/interop.ipynb
- samples/estimation/estimation-qiskit.ipynb
/compiler changes (excluding qsc_qasm3)

The QASM parser doesn't have usable semantic validation, so we have to do a lot of our own validation as we compile the QASM generated from the QuantumCircuits.

Closes #1074


          Setting up initial features

24b7a72

idavis requested review from msoeken and cesarzc

September 3, 2024 22:03

idavis self-assigned this

idavis requested review from minestarks, swernli, billti, sezna, DmitryVasilevsky, tcNickolas and ivanbasov as code owners

September 3, 2024 22:03

github-advanced-security bot found potential problems

View reviewed changes

compiler/qsc_qasm3/src/tests/declaration/complex.rs Fixed Show fixed Hide fixed

idavis requested a review from ScottCarda-MS

September 3, 2024 22:44

msoeken approved these changes

View reviewed changes

Member

msoeken left a comment

Reviewed the RE related parts. Looks good to me. Thanks @idavis !

billti reviewed

View reviewed changes

compiler/qsc_qasm3/Cargo.toml Outdated Show resolved Hide resolved

idavis added 3 commits

September 4, 2024 10:05


          Move oq3_* to workspace

1fdcc33


          Add more tests for complex binops

e520bc5


          Cleaned up tests in other files

c266a60

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/tests/assignment/slices.rs Outdated Show resolved Hide resolved

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/io.rs Outdated Show resolved Hide resolved


          Cleanup from feedback.

02c02b5

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved


          Feedback cleanup

e3b6e57

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Show resolved Hide resolved

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved

idavis added 3 commits

September 4, 2024 13:47


          Adding code docs

0a5c799


          Updating doc comment

55493e1


          Converting unimplemented! to semantic errors

3cb7871

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved

idavis and others added 3 commits

September 6, 2024 10:11


          Updating eslint config to ignore dotted folders.

13e346f


          Update compiler/qsc_qasm3/README.md

d300c13

Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>


          Update compiler/qsc_qasm3/README.md

e93f3be

Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/lib.rs Outdated Show resolved Hide resolved

idavis added 2 commits

September 6, 2024 10:32


          Qualification cleanup

29d425d


          Cleaning up dead code

750b622

minestarks reviewed

View reviewed changes

samples/python_interop/qiskit.ipynb Outdated Show resolved Hide resolved


          Update samples/python_interop/qiskit.ipynb

c923ce5

Co-authored-by: Mine Starks <16928427+minestarks@users.noreply.github.com>

minestarks reviewed

View reviewed changes

samples/estimation/estimation-qiskit.ipynb Show resolved Hide resolved

swernli reviewed

View reviewed changes

compiler/qsc_qasm3/src/angle.rs Outdated Show resolved Hide resolved

swernli reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile/tests.rs Outdated Show resolved Hide resolved

swernli reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved

idavis and others added 3 commits

September 6, 2024 15:04


          Feedback updates

cf063cd


          Update compiler/qsc_qasm3/src/compile/tests.rs

89c7d4b

Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>


          Panic on compiler bug.

f602b08

orpuente-MS reviewed

View reviewed changes

compiler/qsc_qasm3/src/symbols.rs Outdated Show resolved Hide resolved

sezna reviewed

View reviewed changes

compiler/qsc_qasm3/src/angle.rs Show resolved Hide resolved

sezna reviewed

View reviewed changes

eslint.config.mjs Show resolved Hide resolved

sezna approved these changes

View reviewed changes

Contributor

sezna left a comment

approving with a few final comments -- I've tested it and read the code numerous times times, and I think it is certainly ready to go in and have any future improvements handled as future PRs.

Note that I did not review the .py files outside of documentation and general sensibility, as I'm not deep on modern Python idioms or API standards, so it'd be best if you treat this approval as an approval of everything that isn't *.py.

idavis added 2 commits

September 6, 2024 16:26


          Fix old macro ref

e9ae000


          Fmt issues

689a086

minestarks approved these changes

View reviewed changes

Member

minestarks left a comment

Focused on the Python bits, not as much on the compiler internals. Thanks!

orpuente-MS approved these changes

View reviewed changes

Contributor

orpuente-MS left a comment

Approved. I focused on the compiler/ folder.

swernli reviewed

View reviewed changes

compiler/qsc_qasm3/src/compile.rs Outdated Show resolved Hide resolved

swernli approved these changes

View reviewed changes

Collaborator

swernli left a comment

One minor nitpick, not critical before merge but up to you if you want to address it. Excited to see this get in!


          Feedback

756d79c

idavis added this pull request to the merge queue

Merged via the queue into main with commit 83aa5c2

18 checks passed

idavis deleted the iadavis/ast-to-ast branch

September 9, 2024 22:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

billti billti left review comments

orpuente-MS orpuente-MS approved these changes

minestarks minestarks approved these changes

sezna sezna approved these changes

swernli swernli approved these changes

msoeken msoeken approved these changes

cesarzc Awaiting requested review from cesarzc

DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

tcNickolas Awaiting requested review from tcNickolas tcNickolas is a code owner

ivanbasov Awaiting requested review from ivanbasov ivanbasov is a code owner

ScottCarda-MS Awaiting requested review from ScottCarda-MS

Labels

None yet