RCA exports fix #1918
Merged
RCA exports fix #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much 😄 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
This is a follow-up to #1912, and includes an associated RCA bug fix (#1918 ) that was not exposed until I tried to re-export something from `Core`. This also makes a subtle change to the compiler where the prelude is no longer created by default in the namespace tree, and is rather created when we compile `core.qs`. This was needed because we no longer allow "clobbering namespaces", that is, re-opening a namespace from an _external_ package. --------- Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.