Fix to partial evaluation generating branch instructions on constant conditions #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
reviewed
Oct 15, 2024
swernli
approved these changes
Oct 15, 2024
idavis
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA can categorize an expression as dynamic even if it is in fact purely classical. This can happen in cases where a data structure such an array, tuple or UDT contains a mix of static and dynamic values. In such instances, RCA identifies all the contents of the data structure as dynamic even if some values are static. This causes partial evaluation to generate branch instructions on constant conditions under certain circumstances. This change fixes this issue.