Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chemistry lib: readablility, lints, syntax, tests #2202

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Chemistry lib: readablility, lints, syntax, tests #2202

merged 7 commits into from
Feb 27, 2025

Conversation

DmitryVasilevsky
Copy link
Contributor

@DmitryVasilevsky DmitryVasilevsky commented Feb 26, 2025 •
edited
Loading

This change updates chemistry library:

  • Removes old sysntax such as a! and [x, size=5]
  • Reduced use of w/= where possible
  • Makes long argument lists more readable
  • Fixes error in comments
  • Updates pairs of double representing a complex number to use complex type
  • Adds a few unit tests

No renames yet.

@DmitryVasilevsky DmitryVasilevsky changed the title Chemistry lib: remove old syntax, other updates Chemistry lib: readablility, lints, syntax, tests Feb 26, 2025
swernli
swernli approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clean ups are great, thanks for working on this!

Dmitry Vasilevsky added 2 commits February 27, 2025 10:27
@DmitryVasilevsky DmitryVasilevsky mentioned this pull request Feb 27, 2025
Closed
7 tasks
@DmitryVasilevsky DmitryVasilevsky added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 015fb3f Feb 27, 2025
18 checks passed
@DmitryVasilevsky DmitryVasilevsky deleted the dmitryv/chem_lib_updates branch February 27, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msoeken msoeken msoeken approved these changes

@swernli swernli swernli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryVasilevsky @msoeken @swernli