-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic parser error recovery #380
Conversation
Does it make sense to add recovery for statements missing |
Can you be more specific? This PR does recover from statements missing |
Yes, smarter. Resume parsing as if |
The diagnostic error spans are unchanged by this PR, it's the same as on main. I think there are enough changes for infrastructure and refactoring in this PR that I don't want to spend too much time on the recovery behavior itself. I just did basic recovery for items and statements as a proof of concept for the recovery API. There's a long tail of recovery behavior improvements that we can do in follow-up PRs. |
Sounds good. I'll finish reviewing the rest of the PR. |
Add support for error recovery to the scanner, as well as some primitive parsers for ease of use. Include some basic error recovery for items and statements.