Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android static assets images are not loading after update over codepush #2095

Closed
prakashjais99 opened this issue May 18, 2021 · 4 comments
Closed
Labels

Comments

@prakashjais99
Copy link

React native app with Hermes enabled has below res folder structure when release build built from IDE
Screenshot 2021-05-18 at 7 13 43 PM

We have a mono repo setup due to which I can't use appcenter codepush release command
Below are are steps we follow to upload new bundle to appcenter

  1. yarn react-native bundle --platform android --entry-file index.js --bundle-output ./codepush/index.android.bundle.js --assets-dest ./codepush/assets --dev false
  2. ./../node_modules/hermes-engine/osx-bin/hermesc -emit-binary ./index.android.bundle.js -out index.android.bundle -w
  3. appcenter codepush release -a / -c ./codepush -d Staging -t "*"

Below is the generated folder structure

Screenshot 2021-05-18 at 7 24 48 PM

Codepush is updating app successfully. But Static asset images are not getting loaded after the update.

Expected Behavior

Images should work without any issues

Environment

  • react-native-code-push version: 7.0
  • react-native version: 0.63.1-4
  • Android: 7.0
  • Does this reproduce on a debug build or release build - Release build
  • Does this reproduce on a simulator, or only on a physical device: Both device and simulator
@mzdon-ema
Copy link

Looks like you might be having a similar issue I had rendering static SVGs after a CodePush update. I posted the workaround I've been using to fix this. The only limitation is that you can't update static images on Android using a CodePush update.

#2082 (comment)

@alexandergoncharov-zz
Copy link
Contributor

Hi there :)
We merged and published this PR: #2149

Could you please try to reproduce your issue with a new version and let us know if it was successful or not?

@ghost ghost added the stale label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

@ghost
Copy link

ghost commented Dec 28, 2021

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.

@ghost ghost closed this as completed Dec 28, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants