-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: fix new File by only fileName #2149
fix: fix new File by only fileName #2149
Conversation
fix #2148 |
Resolves #2138 To provide a bit more information on why this change is necessary: The directory is then concatenated again to the file name when it is unzipped: react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/FileUtils.java Lines 158 to 159 in b9fb9fb
This doesn't affect JS bundles, as CodePush searches for a bundle as deep as it needs to ( Lines 237 to 239 in b9fb9fb
false as the diff manifest file is actually nested much deeper than we expected. This results in anything other than the jsbundle being "lost".
|
@andreidubov (as the introducer of the bug) or @alexandergoncharov (as an approver) - please could you review this fix? |
@LittleXianyu Thanks for contributing! @ball-hayden Thanks for describing this PR! You guys are awesome :) |
@alexandergoncharov This apparently didn't fix the issue. Still seeing it on 7.0.4. Images disappear on android after a 2nd push is applied. |
Co-authored-by: liuyunpeng <liuyunpeng@innotechx.com>
No description provided.