Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootProject.name overrides application's own name #558

Closed
hakoniemi opened this issue Oct 10, 2016 · 2 comments
Closed

rootProject.name overrides application's own name #558

hakoniemi opened this issue Oct 10, 2016 · 2 comments
Labels
fix-in-master

Comments

@hakoniemi
Copy link

hakoniemi commented Oct 10, 2016 •
edited
Loading

rootProject.name = 'ReactNativeCodePush' overrides the application's own name in settings.gradle and sets it as ReactNativeCodePush for Android. This probably isn't intentional. Is there a way to fix it or should this line be removed: https://github.com/Microsoft/react-native-code-push/blob/master/android/settings.gradle#L1
@richardhuaaa richardhuaaa mentioned this issue Oct 17, 2016
Merged
richardhuaaa pushed a commit that referenced this issue Oct 17, 2016
Remove the project name from settings.gradle (#567)
27029c8 
As mentioned in #558, this line may override the original app's own project name.
@richardhuaaa
Copy link
Contributor

richardhuaaa commented Oct 17, 2016 •
edited
Loading

Hi @Zvona, thanks so much for filing this and apologies for the slow response! That line has been removed and this has been merged into master. We should make a release sometime this week or next week.

@richardhuaaa
Copy link
Contributor

(This was released in 1.15.1-beta (release notes))

@MatheusRochaVipRed MatheusRochaVipRed mentioned this issue Aug 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-in-master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakoniemi @richardhuaaa