This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Сreate postunlink command for clearing CodePush setup changes #1588
Merged
yuri-kulikov
merged 19 commits into
microsoft:master
from
alexandergoncharov-zz:Goncharov/create-postunlink-commands
May 30, 2019
Merged
Сreate postunlink command for clearing CodePush setup changes #1588
yuri-kulikov
merged 19 commits into
microsoft:master
from
alexandergoncharov-zz:Goncharov/create-postunlink-commands
May 30, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-kulikov
approved these changes
May 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, LGTM! 👍
sourabhdebnath
pushed a commit
to scripbox/react-native-code-push
that referenced
this pull request
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
unlink
command doesn't clear CodePush setup changes oflink
command.Solution: Added logic for
unlink
command. Moved duplicate logic totools
folder.Related issue: #1525