Update codepush.gradle #2471

bmaluff · 2023-03-28T17:29:23Z

config was receiving an ArrayList as a false case, but ArrayLists don't support get() method, so it should receive a Map instance.

sureshbakshi · 2023-03-29T17:58:11Z

Hi @bmaluff,

Throwing the below error. PFA
Cannot invoke method get() on a null object

JB-CHAUVIN · 2023-04-03T06:46:50Z

Same error as @sureshbakshi

> Configure project :app
Reading env from: .env

FAILURE: Build failed with an exception.

* Where:
Script '/Users/cegedim/Documents/Cegedim/Code/Mobile/keynote2/packages/mobile-pro/node_modules/react-native-code-push/android/codepush.gradle' line: 6

* What went wrong:
A problem occurred evaluating script.
> Cannot invoke method get() on null object

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

Add more verifications for config variable

bmaluff · 2023-04-03T15:48:40Z

Thanks for the reviews!! Updated the code to fix it according to your findings!!!

bmaluff · 2023-04-03T15:49:36Z

Hi @bmaluff,

Throwing the below error. PFA Cannot invoke method get() on a null object

@sureshbakshi Can you test again, plz?

pavlobu · 2023-05-24T08:41:04Z

Hello, right now I patched changes from this pr and it helped to fix the problem. I hope it will be in release soon

Gamote · 2023-05-30T14:09:48Z

I can confirm that this fixed our issue as well.

We use the following versions:
react-native: 0.64.4
react-native-code-push: 8.0.1

If you use patch-package this is the patch:

react-native-code-push+8.0.1.patch

diff --git a/node_modules/react-native-code-push/android/codepush.gradle b/node_modules/react-native-code-push/android/codepush.gradle
index a0f9d27..09a0951 100644
--- a/node_modules/react-native-code-push/android/codepush.gradle
+++ b/node_modules/react-native-code-push/android/codepush.gradle
@@ -1,9 +1,15 @@
 // Adapted from https://raw.githubusercontent.com/facebook/react-native/d16ff3bd8b92fa84a9007bf5ebedd8153e4c089d/react.gradle
 
+/**
+ * A patch was applied to this file to fix an issue with the CodePush plugin
+ * Issue: https://github.com/microsoft/react-native-code-push/issues/2470#issuecomment-1519511406
+ * Patch: https://github.com/microsoft/react-native-code-push/pull/2471
+ */
+
 import java.nio.file.Paths;
 
-def config = project.extensions.findByName("react") ?: []
-def bundleAssetName = config.bundleAssetName.get() ?: "index.android.bundle"
+def config = project.extensions.findByName("react") ?: [:]
+def bundleAssetName = config.bundleAssetName ? config.bundleAssetName.get() : "index.android.bundle"
 
 // because elvis operator
 def elvisFile(thing) {
@@ -24,7 +30,7 @@ android.buildTypes.each { buildType ->
 }
 
 gradle.projectsEvaluated {
-    def debuggableVariants = config.debuggableVariants.get() ?: ['debug']
+    def debuggableVariants = config.debuggableVariants ? config.debuggableVariants.get() : ['debug']
 
     android.applicationVariants.all { variant ->
         // No code push for debuggable variants
@@ -49,8 +55,8 @@ gradle.projectsEvaluated {
         def jsBundleFile;
 
         // Additional node commandline arguments
-        def nodeExecutableAndArgs = config.nodeExecutableAndArgs.get() ?: ["node"]
-        def extraPackagerArgs = config.extraPackagerArgs.get() ?: []
+        def nodeExecutableAndArgs = config.nodeExecutableAndArgs ? config.nodeExecutableAndArgs.get(): ["node"]
+        def extraPackagerArgs = config.extraPackagerArgs ? config.extraPackagerArgs.get() : []
 
         // Make this task run right after the bundle task
         def generateBundledResourcesHash;
@@ -73,11 +79,11 @@ gradle.projectsEvaluated {
             runBefore("merge${targetName}Assets", generateBundledResourcesHash)
         } else {
             def jsBundleDirConfigName = "jsBundleDir${targetName}"
-            jsBundleDir = elvisFile(config."$jsBundleDirConfigName").get() ?:
+            jsBundleDir = elvisFile(config."$jsBundleDirConfigName") ? elvisFile(config."$jsBundleDirConfigName").get():
                     file("$buildDir/intermediates/assets/${targetPath}")
 
             def resourcesDirConfigName = "resourcesDir${targetName}"
-            resourcesDir = elvisFile(config."${resourcesDirConfigName}").get() ?:
+            resourcesDir = elvisFile(config."${resourcesDirConfigName}") ? elvisFile(config."${resourcesDirConfigName}").get():
                     file("$buildDir/intermediates/res/merged/${targetPath}")
 
             // In case version of 'Android Plugin for Gradle'' is lower than 1.3.0

MateusAndrade · 2023-06-26T14:43:25Z

I can confirm that this fixed our issue as well.

We use the following versions: react-native: 0.64.4 react-native-code-push: 8.0.1

If you use patch-package this is the patch:

react-native-code-push+8.0.1.patch

diff --git a/node_modules/react-native-code-push/android/codepush.gradle b/node_modules/react-native-code-push/android/codepush.gradle
index a0f9d27..09a0951 100644
--- a/node_modules/react-native-code-push/android/codepush.gradle
+++ b/node_modules/react-native-code-push/android/codepush.gradle
@@ -1,9 +1,15 @@
 // Adapted from https://raw.githubusercontent.com/facebook/react-native/d16ff3bd8b92fa84a9007bf5ebedd8153e4c089d/react.gradle
 
+/**
+ * A patch was applied to this file to fix an issue with the CodePush plugin
+ * Issue: https://github.com/microsoft/react-native-code-push/issues/2470#issuecomment-1519511406
+ * Patch: https://github.com/microsoft/react-native-code-push/pull/2471
+ */
+
 import java.nio.file.Paths;
 
-def config = project.extensions.findByName("react") ?: []
-def bundleAssetName = config.bundleAssetName.get() ?: "index.android.bundle"
+def config = project.extensions.findByName("react") ?: [:]
+def bundleAssetName = config.bundleAssetName ? config.bundleAssetName.get() : "index.android.bundle"
 
 // because elvis operator
 def elvisFile(thing) {
@@ -24,7 +30,7 @@ android.buildTypes.each { buildType ->
 }
 
 gradle.projectsEvaluated {
-    def debuggableVariants = config.debuggableVariants.get() ?: ['debug']
+    def debuggableVariants = config.debuggableVariants ? config.debuggableVariants.get() : ['debug']
 
     android.applicationVariants.all { variant ->
         // No code push for debuggable variants
@@ -49,8 +55,8 @@ gradle.projectsEvaluated {
         def jsBundleFile;
 
         // Additional node commandline arguments
-        def nodeExecutableAndArgs = config.nodeExecutableAndArgs.get() ?: ["node"]
-        def extraPackagerArgs = config.extraPackagerArgs.get() ?: []
+        def nodeExecutableAndArgs = config.nodeExecutableAndArgs ? config.nodeExecutableAndArgs.get(): ["node"]
+        def extraPackagerArgs = config.extraPackagerArgs ? config.extraPackagerArgs.get() : []
 
         // Make this task run right after the bundle task
         def generateBundledResourcesHash;
@@ -73,11 +79,11 @@ gradle.projectsEvaluated {
             runBefore("merge${targetName}Assets", generateBundledResourcesHash)
         } else {
             def jsBundleDirConfigName = "jsBundleDir${targetName}"
-            jsBundleDir = elvisFile(config."$jsBundleDirConfigName").get() ?:
+            jsBundleDir = elvisFile(config."$jsBundleDirConfigName") ? elvisFile(config."$jsBundleDirConfigName").get():
                     file("$buildDir/intermediates/assets/${targetPath}")
 
             def resourcesDirConfigName = "resourcesDir${targetName}"
-            resourcesDir = elvisFile(config."${resourcesDirConfigName}").get() ?:
+            resourcesDir = elvisFile(config."${resourcesDirConfigName}") ? elvisFile(config."${resourcesDirConfigName}").get():
                     file("$buildDir/intermediates/res/merged/${targetPath}")
 
             // In case version of 'Android Plugin for Gradle'' is lower than 1.3.0

Using this patch fixed the build error for rn 0.72 🚀

bmaluff · 2023-06-26T17:05:11Z

@DmitriyKirakosyan Can you review this PR so the fix can be available for everyone, plz??

vishpatil1999 · 2023-07-03T12:56:16Z

@MateusAndrade Please provide steps how to use this patch package

Gamote · 2023-07-03T15:25:16Z

@MateusAndrade Please provide steps how to use this patch package

Checkout patch-package for steps on how to install it.

Then create a file out of the code block, call it react-native-code-push+8.0.1.patch and put it into the patches folder.

velimir-jankovic · 2023-11-08T14:04:52Z

@bmaluff Can you please post steps on how to reproduce the issue?

mnikolaus · 2023-11-09T14:16:26Z

Anyone knows why the react extension is not found in extensions and why does config file fallback to empty array?

project.extensions.findByName("react")

I get that this PR fixes wrongly accessed type, but why does it even comes to that?

EDIT: Reverting to v7 fixed the issue

Update codepush.gradle

2a5292e

config was receiving an ArrayList as a false case, but ArrayLists don't support get() method, so it should receive a Map instance.

bmaluff requested a review from a team as a code owner March 28, 2023 17:29

bmaluff mentioned this pull request Mar 28, 2023

No signature of method: java.util.ArrayList.get() is applicable for argument types: () values: [] #2470

Closed

Fix get on null object

dbbc0df

Add more verifications for config variable

Merge branch 'master' into patch-1

00eda63

velimir-jankovic mentioned this pull request Nov 8, 2023

fix(codepush.gradle): config arraylist accessing. #2512

Closed

Merge branch 'master' into patch-1

8d3f988

MikhailSuendukov mentioned this pull request Jan 29, 2024

"No signature of method: java.util.ArrayList.get()" after upgrading react-native-code-push from 7.0.5 to 8.0.1 #2510

Closed

MikhailSuendukov and others added 2 commits April 1, 2024 15:57

Merge branch 'master' into patch-1

3b69f5e

Merge branch 'master' into patch-1

5322333

DmitriyKirakosyan approved these changes Jun 27, 2024

View reviewed changes

lucen-ms approved these changes Jun 27, 2024

View reviewed changes

DordeDimitrijev merged commit 5addacb into microsoft:master Jun 27, 2024
1 of 3 checks passed

DordeDimitrijev mentioned this pull request Jul 8, 2024

Bump version to 8.3.0 #2722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update codepush.gradle #2471

Update codepush.gradle #2471

bmaluff commented Mar 28, 2023

sureshbakshi commented Mar 29, 2023 •

edited

Loading

JB-CHAUVIN commented Apr 3, 2023

bmaluff commented Apr 3, 2023

bmaluff commented Apr 3, 2023

pavlobu commented May 24, 2023

Gamote commented May 30, 2023

MateusAndrade commented Jun 26, 2023

bmaluff commented Jun 26, 2023

vishpatil1999 commented Jul 3, 2023

Gamote commented Jul 3, 2023 •

edited

Loading

velimir-jankovic commented Nov 8, 2023

mnikolaus commented Nov 9, 2023 •

edited

Loading

Update codepush.gradle #2471

Update codepush.gradle #2471

Conversation

bmaluff commented Mar 28, 2023

sureshbakshi commented Mar 29, 2023 • edited Loading

JB-CHAUVIN commented Apr 3, 2023

bmaluff commented Apr 3, 2023

bmaluff commented Apr 3, 2023

pavlobu commented May 24, 2023

Gamote commented May 30, 2023

MateusAndrade commented Jun 26, 2023

bmaluff commented Jun 26, 2023

vishpatil1999 commented Jul 3, 2023

Gamote commented Jul 3, 2023 • edited Loading

velimir-jankovic commented Nov 8, 2023

mnikolaus commented Nov 9, 2023 • edited Loading

sureshbakshi commented Mar 29, 2023 •

edited

Loading

Gamote commented Jul 3, 2023 •

edited

Loading

mnikolaus commented Nov 9, 2023 •

edited

Loading