-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE when invoking copyNecessaryFilesFromCurrentPackage()
method on Android
#2566
Conversation
Hi @robxyy , thank you for the contribution! Let me leave a couple of comments on your change. |
android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateUtils.java
Show resolved
Hide resolved
android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateUtils.java
Show resolved
Hide resolved
android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateUtils.java
Outdated
Show resolved
Hide resolved
Sorry to hear that. I missed |
Fix #2087. It looks like NPE is caused by CodePushUpdateManager.java#L79. When invoking
copyNecessaryFilesFromCurrentPackage()
method, IfcurrentPackageFolderPath
isnull
, copyingcurrentPackageFolderPath
tonewUpdateFolderPath
will be discarded.