Add postlink scripts #450
Merged
Add postlink scripts #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-postlink-hooks
| "code-push": "1.8.0-beta" | ||
| "code-push": "1.8.0-beta", | ||
| "inquirer": "^1.1.2", | ||
| "plist": "^1.2.0" |
There was a problem hiding this comment.
Should we pin these dependencies too?
| @@ -110,6 +114,8 @@ In order to accommodate as many developer preferences as possible, the CodePush | |||
|
|
|||
| *Note: If you don't already have RNPM installed, you can do so by simply running `npm i -g rnpm` and then executing the above command. If you already have RNPM installed, make sure you have v1.9.0+ in order to benefit from this one step install.* | |||
|
|
|||
| 2. You will be prompted for the deployment key you'd like to use. If you don't already have it, you can retreive this value by running `code-push deployment ls <appName> -k`, or you can choose to ignore it (by simply hitting `<ENTER>`) and add it in later. To get started, we would recommend just using your `Staging` deployment key, so that you can test out the CodePush end-to-end. | |||
|
Would it be worth doing something to check that the app version is semver and/or allow them to change it? |
I'm hesitant.. mainly a) I don't see that as part of linking and b) not everyone uses RNPM/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds postlink scripts that RNPM will automatically call when executing
react-native link react-native-code-pushorrnpm link react-native-code-pushso as to simplify setup.Once facebook/react-native#9157 goes through, we can also add
postunlinkscripts as well to simplify removal of our plugin.