Don't recreate identical NSTrackingAreas (#1971)

Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
microsoft · Nov 7, 2023 · 65fb4c0 · 65fb4c0
1 parent 178ff3a
commit 65fb4c0
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/packages/react-native/React/Views/RCTView.m b/packages/react-native/React/Views/RCTView.m
@@ -1492,16 +1492,21 @@ - (BOOL)acceptsFirstResponder
 
 - (void)updateTrackingAreas
 {
- if (_trackingArea) {
- [self removeTrackingArea:_trackingArea];
- }
+ BOOL hasMouseHoverEvent = self.onMouseEnter || self.onMouseLeave;
+ BOOL wouldRecreateIdenticalTrackingArea = hasMouseHoverEvent && _trackingArea && NSEqualRects(self.bounds, [_trackingArea rect]);
+
+ if (!wouldRecreateIdenticalTrackingArea) {
+ if (_trackingArea) {
+ [self removeTrackingArea:_trackingArea];
+ }
 
- if (self.onMouseEnter || self.onMouseLeave) {
- _trackingArea = [[NSTrackingArea alloc] initWithRect:self.bounds
- options:NSTrackingActiveAlways|NSTrackingMouseEnteredAndExited
- owner:self
- userInfo:nil];
- [self addTrackingArea:_trackingArea];
+ if (hasMouseHoverEvent) {
+ _trackingArea = [[NSTrackingArea alloc] initWithRect:self.bounds
+ options:NSTrackingActiveAlways|NSTrackingMouseEnteredAndExited
+ owner:self
+ userInfo:nil];
+ [self addTrackingArea:_trackingArea];
+ }
  }
 
  [super updateTrackingAreas];