fix (iOS): Only try to make the alert window key if the app recognizes it #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Feb 4, 2022
Saadnajmi
reviewed
Feb 4, 2022
Saadnajmi
approved these changes
Feb 5, 2022
HeyImChris
approved these changes
Feb 5, 2022
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Feb 5, 2022
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Feb 5, 2022
HeyImChris
pushed a commit
that referenced
this pull request
Feb 5, 2022
HeyImChris
pushed a commit
that referenced
this pull request
Feb 5, 2022
This was referenced Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This is a follow-up to #917.
In iOS 14, if we call
-[UIWindow makeKeyAndVisible]from aUIWindowthat isn't part of the app, the current key window gets made non-key. This can result inRCTKeyWindow(), and thusly,RCTPresentedViewController(), to come back asnil, which means that the alert never shows up.The fix here is to ensure that we don't try to make the alert window key unless it's actually tracked by the application.
Test Plan
Validated in a downstream app on iOS 14.