[Fabric] Replace UIKit with RCTUIKit shim #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Nov 22, 2022
This was referenced Nov 23, 2022
Saadnajmi
approved these changes
Nov 29, 2022
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Replacing references of UIKit to RCTUIKit shim
Changelog
[macOS][Fabric] - Replacing references of UIKit to RCTUIKit shim
Test Plan
Fabric build errors on main:
Build RNTester-macOS_2022-11-22T14-56-31.txt
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no UIKit errors
Build RNTester-macOS_2022-11-22T14-46-02.txt
[x] Build RNTester - iOS w/ Fabric - should work
CleanShot.2022-11-22.at.15.29.45.mp4
[x] Build RNTester-macOS w/ Paper - should work
CleanShot.2022-11-22.at.15.37.08.mp4
[x] Build RNTester - iOS w/ Paper - should work
CleanShot.2022-11-22.at.15.40.18.mp4