Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix beachball publish #2002

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[CI] Fix beachball publish #2002

merged 1 commit into from
Dec 27, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

Our CI was not properly running beachball publish. I traced this to two issues:

  1. We weren't actually passing in the NPM auth token to beachball. This seems to be a typo from an earlier PR refactoring the publish yml.
  2. One of the packages we inherit from upstream (@react-native/community-cli-plugin) was trying to get published. This was probably introduced / added in a merge, and we didn't add the beachball : { shouldPublish: false } section to our package.json to account. Let's just fix that

Changelog:

[INTERNAL] [FIXED] - Fix beachball publish

Test Plan:

CI should pass.

@Saadnajmi Saadnajmi requested a review from a team as a code owner December 27, 2023 21:27
@Saadnajmi Saadnajmi merged commit bc96e4e into microsoft:main Dec 27, 2023
4 checks passed
@Saadnajmi Saadnajmi deleted the ci-fixes branch December 27, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants