[visionOS] Implement isVision interfaceIdiom #2077
Merged
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR introduces the `vision` interfaceIdiom to check if the app runs on visionOS. An update to the documentation should follow this change. [IOS] [ADDED] - Introduce `vision` interfaceIdiom Pull Request resolved: facebook#42243 Test Plan: This change has been used in `react-native-visionos` and the interfaceIdiom changes **only** when running in the non-compatibility mode. But it's still useful to have this upstream if at some point React native would compile to visionOS natively Reviewed By: cortinico Differential Revision: D52730028 Pulled By: cipolleschi fbshipit-source-id: 711c5c2c6c7fe05b3ff8da7383b5e63e9e04acfa
Summary: This PR is a follow up for facebook#42243 it looks like we need to return `false` for the Platform.android.js to make flow happy. This is the error we were getting in `react-native-visionos` CI/CD:  [INTERNAL] [FIXED] - Add `isVision` interface idiom for Platform.android.js Pull Request resolved: facebook#42381 Test Plan: CI Green Reviewed By: cortinico Differential Revision: D52905993 Pulled By: NickGerleman fbshipit-source-id: 125d33b63e9114cb6276b554e426f32e0c406ea8
This was referenced Feb 17, 2024
Khalef1
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary:
Cherry pick a couple of changes to introduce the
isVisionAPI so that we can write visionOS specific JS. This is a cherry pick of two commits already upstream, plus an extra one to add the method toPlatform.macos.js,Changelog:
[VISIONOS] [ADDED] - Implement isVision interfaceIdiom
Test Plan:
CI should pass