Implement [RCTUITextField selectedRange]
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have a crash internally due to the following error:
This reproes when you move focus programmatically (I.E: through JS with
ref.current.focus()) to a TextInput with 2-Set Korean text already typed. For some reason, that exact code path means that Appkit calls the selector on our TextInput (backed by RCTUITextField in natively) and we crash on the uncaught exception.Fix is to implement the selector.
Test Plan:
CI should pass. Locally, no longer get an
unrecognized selectorexception.