chore: set up proper publishing pipeline #2266
Draft
+1,196
−1,212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/fix-publish
branch
2 times, most recently
from
a9fe079
to
c730181
Compare
Saadnajmi
reviewed
Nov 1, 2024
Saadnajmi
reviewed
Nov 1, 2024
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "$schema": "./node_modules/nx/schemas/nx-schema.json", | |||
| "defaultBase": "main", | |||
There was a problem hiding this comment.
Will this need to change per stable branch?
There was a problem hiding this comment.
Yes, it does if we want diffing to work correctly. Sorry, I meant to make this a draft. It isn't ready for review yet.
.ado/scripts/prepublish-check.mjs
Outdated
Comment on lines
66
to
141
| const { defaultBase, release } = loadNxConfig(); | ||
| if (branch === defaultBase) { | ||
| enablePublishing(release, "nightly", "nightly"); | ||
| } else if (isStableBranch(branch)) { | ||
| enablePublishing(release, "v" + branch, releaseCandidate ? "rc" : undefined); | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess we don't have to change the base per stable branch, nice
There was a problem hiding this comment.
We still need to, but this script should fail if it's not correctly set.
tido64
force-pushed
the
tido/fix-publish
branch
4 times, most recently
from
59a5c9a
to
a335e87
Compare
tido64
force-pushed
the
tido/fix-publish
branch
from
a335e87
to
e4e70f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sets up a publishing pipeline with Nx Release
Test Plan:
TBD