Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessible prop for Image #2327

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Fix accessible prop for Image #2327

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1fa5eca
attempt to set accessibility properties on RCTImageView
ksiler Jan 6, 2025
b57bd3e
Update ImageExample.js
ksiler Jan 6, 2025
6e39eb9
Add reactAccessibilityElementCell in RCTImageView.mm
ksiler Jan 7, 2025
f25b5c5
Map accessible prop to NSImageCell accessibilityElement
ksiler Jan 7, 2025
d47bb60
Update ImageExample.js
ksiler Jan 7, 2025
27e0aaa
Update ImageExample.js
ksiler Jan 7, 2025
0a7e1f4
Update RCTImageViewManager.mm
ksiler Jan 7, 2025
7aae0a8
Update ImageExample.js
ksiler Jan 7, 2025
3df8094
Update ImageExample.js
ksiler Jan 7, 2025
42e1c22
Add diff tags to ImageExample.js
ksiler Jan 7, 2025
69bca6c
Add a few more diff tags to ImageExample.js
ksiler Jan 7, 2025
1e7eba1
Fix lint and prettier errors
ksiler Jan 7, 2025
ac96486
Merge branch 'main' into fixAccessiblePropForImage
ksiler Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native/Libraries/Image/RCTImageView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,11 @@ - (RCTPlatformView *)reactAccessibilityElement
return _imageView;
}

- (NSCell *)reactAccessibilityElementCell
{
return _imageView.cell;
}

- (NSColor *)tintColor
{
return _imageView.tintColor;
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/Libraries/Image/RCTImageViewManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ - (RCTPlatformView *)view // [macOS]
return [[RCTImageView alloc] initWithBridge:self.bridge];
}

RCT_REMAP_VIEW_PROPERTY(accessible, reactAccessibilityElementCell.accessibilityElement, BOOL)
RCT_EXPORT_VIEW_PROPERTY(blurRadius, CGFloat)
RCT_EXPORT_VIEW_PROPERTY(capInsets, UIEdgeInsets)
RCT_REMAP_VIEW_PROPERTY(defaultSource, defaultImage, UIImage)
Expand Down
8 changes: 8 additions & 0 deletions packages/rn-tester/js/examples/Image/ImageExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,6 +1535,14 @@ exports.examples = [
return <Image accessible source={fullImage} style={styles.base} />;
},
},
{
title: 'Accessibility Remove From Tree',
description:
('If the `accessible` (boolean) prop is set to False, the image will be removed from the accessbility tree.': string),
render: function (): React.Node {
return <Image accessible={false} source={fullImage} style={styles.base} />;
},
},
{
title: 'Accessibility Label',
description:
Expand Down
Loading