Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Various fixes #2331

Merged
merged 4 commits into from
Jan 11, 2025
Merged

ci: Various fixes #2331

merged 4 commits into from
Jan 11, 2025
+5 −13

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 10, 2025 •
edited
Loading

Summary:

A couple of fixes:

  • Xcode 16.0 was removed from the macOS 14 image. Use Xcode 16.2
  • We needed to both remove the step to download the visionOS SDK and add a step to download all platforms in Xcode because.. well.. that was the combo that got visionOS to keep building.
  • React Native Test App (off main) uses Node 23's typescript stripping, and we have a job that tests RNTA integration. That means we now need Node 23 as well (@tido64 fyi)

Test Plan:

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 10, 2025 00:21
@Saadnajmi Saadnajmi changed the title ci: use Xcode 16.2 ci: Various fixes Jan 10, 2025
@Saadnajmi Saadnajmi merged commit ff2292f into main Jan 11, 2025
14 checks passed
@Saadnajmi Saadnajmi deleted the Saadnajmi-patch-1 branch January 11, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saadnajmi @tido64