-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock Xcode 12 beta 4 #535
Conversation
|
@@ -9,8 +9,8 @@ | |||
|
|||
#include <TargetConditionals.h> | |||
|
|||
#import <QuartzCore/CADisplayLink.h> // TODO GH#533, we need to explicitly pull in the framework to get the definition for CACurrentMediaTime() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the TODO indicate in this case? From the perspective of a developer who might touch this code next, it's not clear to me what I should keep in mind or try to work towards.
Please select one of the following
Summary
This change is in master but we need to bring it over to the 0.60-stable branch as well since this is the branch sdx-platform is currently consuming.
This is needed to compile on Xcode12 beta 4. Previously we were successfully compiling on beta 2, but as things change between the betas this broke.
The compiler error is that it can't find the definition to a c++ function used for internal performance tracking/logging. We can explicitly include that framework (quartz) for macOS.
Created an OSS issue in this repo to track changes needed for the transition to Xcode 12 via issue #533 .
Changelog
[macOS] [Fixed] - Fix Xcode 12 beta 4 compiler error that we're missing a definition
Test Plan
If it compiles on macOS then it's fixed and shouldn't break anything. Built for iOS/macOS locally on Xcode 12 beta 4. CI will test again on Xcode 11 and soon on Xcode 12 beta 4.
Microsoft Reviewers: Open in CodeFlow