Remove RNTester/RNTester-macOS/TurboModuleCxx and download files from microsoft/react-native-windows #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [podspec] Fix syntax error * [podfile] Specify local files using `:path` option * [podspec] Fix commit hash and source dirname
alloy
requested changes
Oct 5, 2020
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Some files in
RNTester/RNTester-macOS/TurboModuleCxxare copied frommicrosoft/react-native-windowsbefore.This change downloads all of them by cocpapods.
I have created 3 cocoapods in
ReactTurboModuleCxxfolder:*-WinRTPortafter proper files inreact-native-windowsare updated later (very soon)react-native-windows are based on WinRT. Removing the dependency to make them "real" C++ is in the plan.react-native-windows.Changelog
[macOS] [Fixed] - Remove RNTester/RNTester-macOS/TurboModuleCxx and download files from microsoft/react-native-windows
Test Plan
Manually built
NOTE: This change affects the
snapshot/screenshottest page, but the test page was broken before I made this change. I will address it in another pull request.Microsoft Reviewers: Open in CodeFlow