-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some robustness to the CI and switch to Xcode 12 #709
Changes from all commits
8df39e1
4a9bcbd
e8d2d8b
ab71c3b
e40c784
204ddb3
a76bcc1
7d85560
7011dc4
abfbabf
19aa189
8206128
23be475
3b2c1c7
ea4f432
41fd8d4
bc002f5
f01c601
5df978e
645ccf0
fcbb23e
1796f80
a5204c1
2655ce1
976c049
4cf4987
63004c7
b549e2b
e4fd236
98ed06c
a2810b5
0d3ab65
dfbd871
ba3c3c2
08378e7
184a65b
56a5b1d
efbc5ad
e45897d
3a83bb8
547dbbc
87018a9
f196737
b02f85a
6449ad5
fbe63db
f55a999
159dce1
19f4a9c
915000d
cda139d
cf5a61a
933ff87
677c467
1cd4f9a
b5610db
2c99a1f
95893fa
b6be4de
c6f2eb8
221146e
d856945
100a567
54973f6
b46db1d
2a5eb8c
eb266fe
65b84b6
156965e
51725ed
2012916
29d1286
1f75063
2970187
3ad4df6
ac37210
d8f7530
22e74c4
06f74ba
ff9c754
a583264
7d43df0
72c2659
2fa4dd9
ae75fb6
99fa848
faa49d4
67e663b
4d5c7b8
9d9d8fa
17e61c9
c3b686f
caac984
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
# | ||
# Task Group: XCode select proper version | ||
# Task Group: Xcode select proper version | ||
# | ||
|
||
parameters: | ||
slice_name: '' | ||
xcode_version: '' | ||
|
||
steps: | ||
- bash: | | ||
sudo xcode-select --switch '/Applications/Xcode_11.2.1.app' | ||
displayName: 'Switch to XCode 11.2.1' | ||
sudo xcode-select --switch '${{ parameters.xcode_version }}' | ||
displayName: Switch Xcode version ${{ parameters.slice_name }} | ||
failOnStderr: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
variables: | ||
VmImage: macOS-10.14 | ||
VmImage: macOS-10.15 | ||
slice_name: 'Xcode_12_4' | ||
xcode_version: '/Applications/Xcode_12.4.app' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ Pod::Spec.new do |s| | |
s.documentation_url = "https://reactnative.dev/docs/actionsheetios" | ||
s.license = package["license"] | ||
s.author = "Facebook, Inc. and its affiliates" | ||
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ios=>"13.0" it will make our sizes small too... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo. Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream) |
||
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214) | ||
s.source = source | ||
s.source_files = "*.{m}" | ||
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.