Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some robustness to the CI and switch to Xcode 12 #709

Merged
merged 93 commits into from
Mar 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
8df39e1
Update RCTCxxBridge.mm
HeyImChris May 14, 2020
4a9bcbd
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Jun 1, 2020
e8d2d8b
Merge pull request #1 from microsoft/master
HeyImChris Aug 17, 2020
ab71c3b
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Sep 3, 2020
e40c784
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Sep 8, 2020
204ddb3
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Sep 16, 2020
a76bcc1
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Nov 27, 2020
7d85560
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Dec 4, 2020
7011dc4
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Dec 11, 2020
abfbabf
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Jan 13, 2021
19aa189
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Jan 25, 2021
8206128
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
23be475
update to xcode 12.4
HeyImChris Feb 5, 2021
3b2c1c7
use apple variables file
HeyImChris Feb 5, 2021
ea4f432
Update RCTCxxBridge.mm
HeyImChris May 14, 2020
41fd8d4
Merge branch 'master' of https://github.com/HeyImChris/react-native-m…
HeyImChris Feb 5, 2021
bc002f5
add quotes
HeyImChris Feb 10, 2021
f01c601
switch to catalina
HeyImChris Feb 10, 2021
5df978e
update pods to 10.15
HeyImChris Feb 10, 2021
645ccf0
Merge branch 'master' of https://github.com/HeyImChris/react-native-m…
HeyImChris Feb 12, 2021
fcbb23e
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
1796f80
update to xcode 12.4
HeyImChris Feb 5, 2021
a5204c1
use apple variables file
HeyImChris Feb 5, 2021
2655ce1
add quotes
HeyImChris Feb 10, 2021
976c049
switch to catalina
HeyImChris Feb 10, 2021
4cf4987
update pods to 10.15
HeyImChris Feb 10, 2021
63004c7
upgrade version requirements to n-2 for osx
HeyImChris Feb 12, 2021
b549e2b
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris Feb 12, 2021
e4fd236
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
98ed06c
update to xcode 12.4
HeyImChris Feb 5, 2021
a2810b5
use apple variables file
HeyImChris Feb 5, 2021
0d3ab65
add quotes
HeyImChris Feb 10, 2021
dfbd871
switch to catalina
HeyImChris Feb 10, 2021
ba3c3c2
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris Feb 12, 2021
08378e7
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
184a65b
update to xcode 12.4
HeyImChris Feb 5, 2021
56a5b1d
use apple variables file
HeyImChris Feb 5, 2021
efbc5ad
add quotes
HeyImChris Feb 10, 2021
e45897d
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris Feb 26, 2021
3a83bb8
Merge branch 'master' into xcode12
HeyImChris Feb 26, 2021
547dbbc
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
87018a9
update to xcode 12.4
HeyImChris Feb 5, 2021
f196737
use apple variables file
HeyImChris Feb 5, 2021
b02f85a
add quotes
HeyImChris Feb 10, 2021
6449ad5
CI should run on PRs to future stable branches (#718)
acoates-ms Feb 12, 2021
fbe63db
Pull in header's C declaration to stop symbol mangling (#728)
HeyImChris Feb 18, 2021
f55a999
scroll content with animation (#725)
marty-wang Feb 18, 2021
159dce1
Fix missing props on secure text input (#719)
appden Feb 18, 2021
19f4a9c
Enable animated gif playback on Mac (#724)
marty-wang Feb 22, 2021
915000d
Add explicit Tab support to keyboarding (#723)
HeyImChris Feb 26, 2021
cda139d
Fix Deadlock in RCTi18nUtil (iOS) (#733)
Saadnajmi Feb 26, 2021
cf5a61a
update to macOS 10.15
HeyImChris Mar 2, 2021
933ff87
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris Mar 2, 2021
677c467
Merge branch 'master' into xcode12
HeyImChris Mar 2, 2021
1cd4f9a
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Mar 9, 2021
b5610db
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
2c99a1f
update to xcode 12.4
HeyImChris Feb 5, 2021
95893fa
use apple variables file
HeyImChris Feb 5, 2021
b6be4de
add quotes
HeyImChris Feb 10, 2021
c6f2eb8
switch to catalina
HeyImChris Feb 10, 2021
221146e
update pods to 10.15
HeyImChris Feb 10, 2021
d856945
upgrade version requirements to n-2 for osx
HeyImChris Feb 12, 2021
100a567
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
54973f6
update to xcode 12.4
HeyImChris Feb 5, 2021
b46db1d
use apple variables file
HeyImChris Feb 5, 2021
2a5eb8c
add quotes
HeyImChris Feb 10, 2021
eb266fe
switch to catalina
HeyImChris Feb 10, 2021
65b84b6
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
156965e
update to xcode 12.4
HeyImChris Feb 5, 2021
51725ed
use apple variables file
HeyImChris Feb 5, 2021
2012916
add quotes
HeyImChris Feb 10, 2021
29d1286
make CI xcode versioning more robust to xcode12
HeyImChris Feb 4, 2021
1f75063
update to xcode 12.4
HeyImChris Feb 5, 2021
2970187
use apple variables file
HeyImChris Feb 5, 2021
3ad4df6
add quotes
HeyImChris Feb 10, 2021
ac37210
update to macOS 10.15
HeyImChris Mar 2, 2021
d8f7530
update to xcode 12.4
HeyImChris Feb 5, 2021
22e74c4
use apple variables file
HeyImChris Feb 5, 2021
06f74ba
switch to catalina
HeyImChris Feb 10, 2021
ff9c754
10.14
HeyImChris Mar 9, 2021
a583264
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris Mar 9, 2021
7d43df0
CI has to run on 10.15.4 or later
HeyImChris Mar 10, 2021
72c2659
fix up pod errors
HeyImChris Mar 10, 2021
2fa4dd9
upgrade iphone simulator
HeyImChris Mar 10, 2021
ae75fb6
iphone 13
HeyImChris Mar 10, 2021
99fa848
remove old post install script
HeyImChris Mar 11, 2021
faa49d4
iphone 8
HeyImChris Mar 11, 2021
67e663b
Restore Podfile.lock to see if it fixes CI
anandrajeswaran Mar 12, 2021
4d5c7b8
Restore compiler flags in TurboModuleCxx-WinRTPort
anandrajeswaran Mar 12, 2021
9d9d8fa
Remove macOS arm64 build divergence
anandrajeswaran Mar 12, 2021
17e61c9
Remove building all ARCHS temporarily
anandrajeswaran Mar 12, 2021
c3b686f
Override ONLY_ACTIVE_ARCH in release builds too
anandrajeswaran Mar 12, 2021
caac984
Push iOS 14 snapshots
anandrajeswaran Mar 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ado/ado-test-cleanup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -ex

# Script used by the Azure DevOps build agent to cleanup the packager and web socket server
# after the XCode test step has completed
# after the Xcode test step has completed

# kill whatever is occupying port 8081 (packager)
lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
Expand Down
4 changes: 4 additions & 0 deletions .ado/apple-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
- template: templates/apple-job-javascript.yml
parameters:
apply_office_patches: $(apply_office_patches)
slice_name: $(slice_name)
xcode_version: $(xcode_version)

- job: AppleRNPR
displayName: Apple React Native PR
Expand Down Expand Up @@ -84,6 +86,8 @@ jobs:
xcode_actions_release: $(xcode_actions_release)
xcode_destination: $(xcode_destination)
apply_office_patches: $(apply_office_patches)
slice_name: $(slice_name)
xcode_version: $(xcode_version)

- job: CliInit
displayName: Verify react-native-macos-init
Expand Down
6 changes: 6 additions & 0 deletions .ado/templates/apple-job-javascript.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
parameters:
apply_office_patches: ''
slice_name: ''
xcode_version: ''

steps:
- template: apple-node-setup.yml

# Task Group: Xcode select proper version
- template: apple-xcode-select.yml
parameters:
slice_name: ${{ parameters.slice_name }}
xcode_version: ${{ parameters.xcode_version }}

- template: apple-droid-node-patching.yml
parameters:
Expand Down
5 changes: 5 additions & 0 deletions .ado/templates/apple-job-react-native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ parameters:
xcode_actions_release: ''
xcode_destination: ''
apply_office_patches: ''
slice_name: ''
xcode_version: ''

steps:
# Clean DerivedData
Expand All @@ -18,6 +20,9 @@ steps:

# Task Group: Xcode select proper version
- template: apple-xcode-select.yml
parameters:
slice_name: ${{ parameters.slice_name }}
xcode_version: ${{ parameters.xcode_version }}

- template: apple-droid-node-patching.yml
parameters:
Expand Down
4 changes: 2 additions & 2 deletions .ado/templates/apple-xcode-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ parameters:

steps:
- task: Xcode@5
displayName: 'XCode ${{ parameters.xcode_actions }} ${{ parameters.xcode_configuration }} ${{ parameters.xcode_sdk }} ${{ parameters.xcode_scheme }}'
displayName: 'Xcode ${{ parameters.xcode_actions }} ${{ parameters.xcode_configuration }} ${{ parameters.xcode_sdk }} ${{ parameters.xcode_scheme }}'
inputs:
actions: '${{ parameters.xcode_actions }}'
configuration: ${{ parameters.xcode_configuration }}
Expand All @@ -21,7 +21,7 @@ steps:
signingOption: auto
packageApp: false
teamId: '$(XCodeSigningMicrosoftTeamID)'
args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=YES -verbose -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'
exportPath: '$(agent.builddirectory)/output/${{ parameters.xcode_sdk }}/${{ parameters.xcode_configuration }}'
useXcpretty: ${{ parameters.xcode_useXcpretty }}
publishJUnitResults: ${{ parameters.xcode_useXcpretty }}
Expand Down
11 changes: 8 additions & 3 deletions .ado/templates/apple-xcode-select.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
#
# Task Group: XCode select proper version
# Task Group: Xcode select proper version
#

parameters:
slice_name: ''
xcode_version: ''

steps:
- bash: |
sudo xcode-select --switch '/Applications/Xcode_11.2.1.app'
displayName: 'Switch to XCode 11.2.1'
sudo xcode-select --switch '${{ parameters.xcode_version }}'
displayName: Switch Xcode version ${{ parameters.slice_name }}
failOnStderr: true
4 changes: 3 additions & 1 deletion .ado/variables/mac.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
variables:
VmImage: macOS-10.14
VmImage: macOS-10.15
slice_name: 'Xcode_12_4'
xcode_version: '/Applications/Xcode_12.4.app'
2 changes: 1 addition & 1 deletion Libraries/ART/React-ART.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.source = source
s.source_files = "**/*.{m}"
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/ActionSheetIOS/React-RCTActionSheet.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios=>"13.0" it will make our sizes small too...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.

Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.source = source
s.source_files = "*.{m}"
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Blob/React-RCTBlob.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/FBLazyVector/FBLazyVector.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS ISS#2323203)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS ISS#2323203)
s.source = source
s.source_files = "**/*.{c,h,m,mm,cpp}"
s.header_dir = "FBLazyVector"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/FBReactNativeSpec/FBReactNativeSpec.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS ISS#2323203)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS ISS#2323203)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "**/*.{c,h,m,mm,cpp}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Image/React-RCTImage.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/image"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/LinkingIOS/React-RCTLinking.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/linking"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/NativeAnimation/React-RCTAnimation.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "{Drivers/*,Nodes/*,*}.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Network/React-RCTNetwork.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/pushnotificationios"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/RCTRequired/RCTRequired.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS ISS#2323203)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS ISS#2323203)
s.source = source
s.source_files = "**/*.{c,h,m,mm,cpp}"
s.header_dir = "RCTRequired"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Settings/React-RCTSettings.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/settings"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Text/React-RCTText.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/text"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.source = source
s.source_files = "**/*.{h,m}"
s.ios.exclude_files = "**/macOS/*" # TODO(macOS ISS#2323203)
Expand Down
2 changes: 1 addition & 1 deletion Libraries/TypeSafety/RCTTypeSafety.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS ISS#2323203)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS ISS#2323203)
s.compiler_flags = folly_compiler_flags
s.source = source
s.source_files = "**/*.{c,h,m,mm,cpp}"
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Vibration/React-RCTVibration.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |s|
s.documentation_url = "https://reactnative.dev/docs/vibration"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "*.{m,mm}"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ You can read more about the macOS implementation in our website - [React Native

## Requirements

You can run React Native for macOS apps on Mac devices with versions [High Sierra (10.13)](https://www.apple.com/newsroom/2017/09/macos-high-sierra-now-available-as-a-free-update/) or newer.
You can run React Native for macOS apps on Mac devices with versions Mojave (10.14) or newer.

For a full and detailed list of the system requirements and how to set up your development platform, see our [System Requirements](https://microsoft.github.io/react-native-windows/docs/rnm-dependencies) documentation on our website.

Expand Down
15 changes: 0 additions & 15 deletions RNTester/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,4 @@ end

post_install do |installer|
flipper_post_install(installer)
installer.pods_project.targets.each do |target|
# [TODO(macOS ISS#2323203): the internal Microsoft build pipeline needs iOS arm64e slices
if target.platform_name == :ios
target.build_configurations.each do |config|
(config.build_settings['ARCHS'] ||= ['$(ARCHS_STANDARD)']) << 'arm64e'
end
end
# TODO(macOS ISS#2323203): the internal Microsoft build pipeline needs macOS arm64 slices
if target.platform_name == :osx
target.build_configurations.each do |config|
(config.build_settings['ARCHS'] ||= ['$(ARCHS_STANDARD)']) << ' arm64'
end
end
# ]TODO(macOS ISS#2323203)
end
end
70 changes: 35 additions & 35 deletions RNTester/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -516,52 +516,52 @@ EXTERNAL SOURCES:
:path: "../ReactCommon/yoga"

SPEC CHECKSUMS:
boost-for-react-native: dabda8622e76020607c2ae1e65cc0cda8b61479d
boost-for-react-native: a110407d9db2642fd2e1bcd7c5a51c81f2521dc9
CocoaAsyncSocket: 694058e7c0ed05a9e217d1b3c7ded962f4180845
CocoaLibEvent: 2fab71b8bd46dd33ddb959f7928ec5909f838e3f
DoubleConversion: 56a44bcfd14ab2ff66f5a146b2e875eb4b69b19b
FBLazyVector: 33306016e21286a3ebf05b2e74758ecb51b487cb
FBReactNativeSpec: eba7c1b592e557c3d328af72fcd04fa5ad9dc732
DoubleConversion: 2b45d0f8e156a5b02354c8a4062de64d41ccb4e0
FBLazyVector: 92d78d01de741fe34b2d751e55a037653358ac0c
FBReactNativeSpec: e8382054abb3fb8270af2bca565a9f0577830525
Flipper: be611d4b742d8c87fbae2ca5f44603a02539e365
Flipper-DoubleConversion: 38631e41ef4f9b12861c67d17cb5518d06badc41
Flipper-Folly: c12092ea368353b58e992843a990a3225d4533c3
Flipper-Glog: 1dfd6abf1e922806c52ceb8701a3599a79a200a6
Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
Flipper-RSocket: 64e7431a55835eb953b0bf984ef3b90ae9fdddd7
FlipperKit: ab353d41aea8aae2ea6daaf813e67496642f3d7d
glog: 1cb7c408c781ae8f35bbababe459b45e3dee4ec1
glog: 789873d01e4b200777d0a09bc23d548446758699
hermes: 12d049af0d8e8379c5b3b54ffb1919d670045bdc
libevent: ee9265726a1fc599dea382964fa304378affaa5f
libevent: 59938c595b8c19e50c83250628ffed9ebf662183
OpenSSL-Universal: 8b48cc0d10c1b2923617dfe5c178aa9ed2689355
RCT-Folly: 1347093ffe75e152d846f7e45a3ef901b60021aa
RCTRequired: c1be2a438c43a3bbaae1c648944e74f09bf7b6df
RCTTypeSafety: 8a51d44eafbc4d6b845f4bf158973cb15017af4a
React: cd84a8114f257b60d426051214bb220e01f31853
React-ART: dc713fc5e6fc9d91111ac8dcc36f423edaf726db
React-callinvoker: 22c4350c8d512f0c4d28c652de164d261790eee3
React-Core: 301a9137b800e78e100804b201a2751eba784396
React-CoreModules: 1f63ebf5afc57f1182c29d071f1d0b36729d3c1e
React-cxxreact: 4d4c317d32055a60063d6788962df6d8e5e959a9
React-jsi: 5130ca982064487449da1e916815a2ab17c8b5f0
React-jsiexecutor: fbc8b1046ca4a8a9b5fc1e92e506a96e22600f5f
React-jsinspector: dbed1bb565004515d7470a54673da99cd36d6ac8
React-RCTActionSheet: 8d7d186c02a07c96ff8b4193c39c829003d5e401
React-RCTAnimation: 769775382fcb0fd801bc0e8c4ba69b112b605e97
React-RCTBlob: c0e2dba349e77aa3ccbc99b1c61f0f8ba53b6add
React-RCTImage: d1424690347182fd14183d471fb756542b9645b8
React-RCTLinking: f8d483d3e8e4bcc2749e67d5f68b8006dfe5eb3d
React-RCTNetwork: 7d4f1caaae3b87a9c3e924eeea4805a3bcaf9144
React-RCTPushNotification: 03dc947964f5c2a3c53389e7c386b5b8bcef2b17
React-RCTSettings: 6be17236bffccbcfa3a57dd961b7682998a92a11
React-RCTTest: 0de4043839e8b9782e9ca4c3ecaf7c6dace48027
React-RCTText: efcbbf74281e0c42f0c7737c8cc0f148b3cf8983
React-RCTVibration: 45f0a1b6780752f516bf81717cfdf901896e93a7
React-TurboModuleCxx-RNW: 4da8eb44b10ab3c5bbab9fcb0a8ae415c20ea3c9
React-TurboModuleCxx-WinRTPort: 723f549e1b886bae14bf16b6ef8420aef0d3f190
ReactCommon: 24aa1f1de935591060e0730148c0d85da7567214
Yoga: e009ba9e81fe6c0b4067e62295faa522982b3860
RCT-Folly: 55d0039b24e192081ec0b2257f7bd9f42e382fb7
RCTRequired: 12daee8719711b00cac01ab3f90678356431596e
RCTTypeSafety: a4fd9c36901830973a05d074afc75a5147b3e6f2
React: 7cf7caa74c0c289d292ae2b2022a259e83b1c4c3
React-ART: d50f359f8ba778f8d184cd4b7d5bade4bd3aad81
React-callinvoker: 366e5648b012f7b02e1577d6c3d021763a10c9cc
React-Core: 712fe9e8aedce8c8f27d46f171a899487617403f
React-CoreModules: 75fc59024dea0708b2da5415298f491881de74e7
React-cxxreact: 1935fb10e2eecdcea1b225b6679e329b00889611
React-jsi: f7c5b9f6ed6bcc2b3ee6aa7a791d317ccbb8313f
React-jsiexecutor: cea9a058f0fcb1b8d4c1fad3fc3bb5088c2979bd
React-jsinspector: 6b83e9193f44d73358302e53a913e932c385cfa7
React-RCTActionSheet: 3f81bc159b69758f2c859f3cd85b15bb9c223ecb
React-RCTAnimation: af41afc5b073b180274fcdb2026b9b7b10c3b798
React-RCTBlob: 5a48ac364cc476941099367f5fbeffee0673fa87
React-RCTImage: 39e2de7650342313728d40955fabd278e5c4c134
React-RCTLinking: ed8eb075cff2349e89402663585ffef0381848a2
React-RCTNetwork: 9de10fa1593b0db1cca5bbfd5b2a82e809c8758b
React-RCTPushNotification: 1e7591f9ef1fa557f017b1eaf99e5c88fd5c8e6f
React-RCTSettings: e7a081bcc8c518ce59749ba3803a040f90483ffc
React-RCTTest: aa3ca9247f85c78eee060d74d4a8dbdb0e90c47e
React-RCTText: efbf71e9af9d6e6a7f9fa5ac87b4bd8baf1d8249
React-RCTVibration: d8ef2a3e93ebb0de2c4e0dbbaee56cdd54c5441b
React-TurboModuleCxx-RNW: 18bb71af41fe34c8b12a56bef60aae7ee32b0817
React-TurboModuleCxx-WinRTPort: 4719553bda4c93a64b8e1d6a474a8afceb49419c
ReactCommon: f399d6afd467e33cc3042a9f2eed99e9b8c57eb3
Yoga: 831921041b154f425e43cd8c236502457c632d71
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: 18ca7d3b0e7db79041574a8bb6200b9e1c2d5359
PODFILE CHECKSUM: baaa75a5807a228f32c4218f28c9260336518038

COCOAPODS: 1.9.3
COCOAPODS: 1.9.1
2 changes: 1 addition & 1 deletion RNTester/RCTTest/React-RCTTest.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.homepage = "https://reactnative.dev/"
s.license = package["license"]
s.author = "Facebook, Inc. and its affiliates"
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)
s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.14" } # TODO(macOS GH#214)
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "**/*.{h,m,mm}"
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading