Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ADO to Xcode 13 #993

Closed
wants to merge 8 commits into from
Closed

Move ADO to Xcode 13 #993

wants to merge 8 commits into from

Conversation

HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Now 0.66 merged into our fork, we can make the upgrade to Xcode 13. Xcode 13 requires a Mac running macOS 11.3 or later so upgrade our OS and move Xcode with it.

@HeyImChris HeyImChris requested a review from alloy as a code owner January 27, 2022 00:28
@HeyImChris HeyImChris self-assigned this Jan 27, 2022
@Saadnajmi
Copy link
Collaborator

@kelset is doing a similar change with #979
Might want to coordinate there.

@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 6d79af1

@HeyImChris
Copy link
Author

@kelset is doing a similar change with #979
Might want to coordinate there.

Good point, his covers what we need plus does a bit more other clean up. I can close this one and help him get his CI passing to get that review in.

@HeyImChris HeyImChris closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants