Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple): disable deterministic_uuids starting with 0.73 #1633

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(apple): disable deterministic_uuids starting with 0.73 #1633

merged 1 commit into from
Oct 9, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 9, 2023 •
edited
Loading

Description

Disable deterministic_uuids starting with 0.73.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version 0.73
# Manually remove react-native-macos from both `package.json` and `example/package.json`
yarn
cd example
rm ios/Podfile.lock
pod install --project-directory=ios

@tido64 tido64 requested a review from kelset October 9, 2023 09:08
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Oct 9, 2023
kelset
kelset approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tido64 tido64 merged commit 9ed0a83 into trunk Oct 9, 2023
27 checks passed
@tido64 tido64 deleted the tido/ios/prep-0.73 branch October 9, 2023 12:09
@Saadnajmi
Copy link
Collaborator

Is this just because RN-macOS already did this, or did something change?

@tido64
Copy link
Member Author

tido64 commented Oct 9, 2023

Is this just because RN-macOS already did this, or did something change?

Not sure. This line was introduced in 0.68, but you really only needed it if you enable Fabric. In 0.73, I'm seeing this even without Fabric so it looks like some files are being generated regardless now.

@Saadnajmi
Copy link
Collaborator

Ah, it's done upstream too. Interesting.

@tido64 tido64 mentioned this pull request Oct 10, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @Saadnajmi @kelset