Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): deprecate :use_turbomodule for :use_fabric #1766

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix(ios): deprecate :use_turbomodule for :use_fabric #1766

merged 1 commit into from
Jan 16, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 12, 2024

Description

To better align with react-native, we will no longer maintain separate Fabric and Turbo Modules options. Enabling Fabric now will be the same as enabling New Architecture.

:use_turbomodule will still be present, but you should consider migrating to :use_fabric. We will remove the former in the next major release.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

# Run full test matrix for current version
node scripts/test-matrix.mjs

# Verify that `:use_turbomodule => true` still works
sed -i '' 's/fabric_enabled/turbomodule_enabled/' example/ios/Podfile
cd example
pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

Verify that Fabric was enabled.

@tido64
fix(ios): deprecate :use_turbomodule for :use_fabric
a68914d 
To better align with `react-native`, we will no longer maintain separate
Fabric and Turbo Modules options. Enabling Fabric now will be the same
as enabling New Architecture.

`:use_turbomodule` will still be present, but you should consider
migrating to `:use_fabric`. We will remove the former in the next major
release.
@tido64 tido64 requested a review from kelset January 12, 2024 14:40
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Jan 12, 2024
@tido64 tido64 mentioned this pull request Jan 12, 2024
Closed
33 tasks
kelset
kelset approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and changes LGTM.

Let's 🚢 this
Simulator Screenshot - iPhone 15 Pro - 2024-01-16 at 15 10 22

@tido64 tido64 merged commit f1ad3ea into trunk Jan 16, 2024
27 checks passed
@tido64 tido64 deleted the tido/deprecate-use_turbomodule branch January 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @kelset