Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): use default app setup for New Arch #1774

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 16, 2024

Description

Use default app setup for New Arch as it includes a lot of the things that we had to manually implement. Incidentally, this also fixes the crash we had on startup with 0.74 + New Arch.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Run the following for 0.71, 0.74:

npm run set-react-version 0.71
sed -i '' 's/#newArchEnabled/newArchEnabled/' example/android/gradle.properties
yarn
cd example
yarn android

# In a separate terminal
yarn start

Screenshots

0.71 0.72 0.74
Screenshot_1705418147 Screenshot_1705417852 Screenshot_1705418519

@tido64 tido64 requested a review from kelset January 16, 2024 15:28
@github-actions github-actions bot added the platform: Android This affects Android label Jan 16, 2024
@tido64 tido64 mentioned this pull request Jan 16, 2024
33 tasks
@kelset
Copy link
Contributor

kelset commented Jan 19, 2024

Tested, here are the screenshots:

0.71 0.72 0.74
Screenshot_1705675500 Screenshot_1705675952 Screenshot_1705677330

had to jump through a few hoops like the macos problem we are having with their nightlies - but aside from that it all works.

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tido64 tido64 merged commit 558a6e1 into trunk Jan 19, 2024
27 checks passed
@tido64 tido64 deleted the tido/use-default-rnh branch January 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants