Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): hook up C++ TurboModules autolinking #1868

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix(android): hook up C++ TurboModules autolinking #1868

merged 1 commit into from
Feb 23, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Feb 22, 2024 •
edited
Loading

Description

Hook up C++ TurboModules autolinking: facebook/react-native@4ecf57e

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Run the following for 0.73 and 0.74:

npm run set-react-version 0.74 -- --core-only
# If 0.74, remove `@react-native-webapis/web-storage` from `example/package.json`
yarn
cd example/android
./gradlew assembleDebug -PnewArchEnabled=true

Build should succeed.

@tido64 tido64 requested a review from kelset as a code owner February 22, 2024 13:23
@tido64 tido64 mentioned this pull request Feb 22, 2024
Closed
33 tasks
@github-actions github-actions bot added the platform: Android This affects Android label Feb 22, 2024
@tido64 tido64 merged commit b60588b into trunk Feb 23, 2024
27 checks passed
@tido64 tido64 deleted the tido/autolink-cpp-modules branch February 23, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi