Skip to content

fix(android): fix 'cannot find react-native' error on 0.80 #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix(android): fix 'cannot find react-native' error on 0.80 #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9015f
fix(android): fix 'cannot find `react-native`' error on 0.80
tido64 Mar 31, 2025
62e657b
0.80, not 0.79
tido64 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,19 @@ buildscript {

allprojects {
repositories {
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url({
def searchDir = rootDir.toPath()
do {
def p = searchDir.resolve("node_modules/react-native/android")
if (p.toFile().exists()) {
return p.toRealPath().toString()
{
def searchDir = rootDir.toPath()
do {
def p = searchDir.resolve("node_modules/react-native/android")
if (p.toFile().exists()) {
maven {
url(p.toRealPath().toString())
}
} while (searchDir = searchDir.getParent())
throw new GradleException("Could not find `react-native`");
}())
}
break
}
} while (searchDir = searchDir.getParent())
// As of 0.80, React Native is no longer installed from npm
}()
mavenCentral()
google()
}
Expand Down
24 changes: 12 additions & 12 deletions scripts/template.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,19 @@ export function buildGradle() {
// https://github.com/facebook/react-native/commit/51a48d2e2c64a18012692b063368e369cd8ff797
"allprojects {",
" repositories {",
" maven {",
" // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm",
" url({",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" return p.toRealPath().toString()",
" {",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" }",
" } while (searchDir = searchDir.getParent())",
' throw new GradleException("Could not find `react-native`");',
" }())",
" }",
" break",
" }",
" } while (searchDir = searchDir.getParent())",
" // As of 0.80, React Native is no longer installed from npm",
" }()",
" mavenCentral()",
" google()",
" }",
Expand Down
48 changes: 24 additions & 24 deletions test/configure/gatherConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,19 @@ describe("gatherConfig()", () => {
"",
"allprojects {",
" repositories {",
" maven {",
" // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm",
" url({",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" return p.toRealPath().toString()",
" {",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" }",
" } while (searchDir = searchDir.getParent())",
' throw new GradleException("Could not find `react-native`");',
" }())",
" }",
" break",
" }",
" } while (searchDir = searchDir.getParent())",
" // As of 0.80, React Native is no longer installed from npm",
" }()",
" mavenCentral()",
" google()",
" }",
Expand Down Expand Up @@ -427,19 +427,19 @@ describe("gatherConfig()", () => {
"",
"allprojects {",
" repositories {",
" maven {",
" // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm",
" url({",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" return p.toRealPath().toString()",
" {",
" def searchDir = rootDir.toPath()",
" do {",
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" }",
" } while (searchDir = searchDir.getParent())",
' throw new GradleException("Could not find `react-native`");',
" }())",
" }",
" break",
" }",
" } while (searchDir = searchDir.getParent())",
" // As of 0.80, React Native is no longer installed from npm",
" }()",
" mavenCentral()",
" google()",
" }",
Expand Down
Loading